[GitHub] [hbase] curie71 commented on pull request #4951: HBASE-27528 log duplication issues in MasterRpcServices.

2023-01-21 Thread via GitHub


curie71 commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1399398660

   > I mean the removal seems OK, as if we do not enable AccessChecker, it does 
not make sense to call grant and revoke methods.
   
   Thanks for your review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] curie71 commented on pull request #4951: HBASE-27528 log duplication issues in MasterRpcServices.

2023-01-09 Thread GitBox


curie71 commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1376685476

   > 
   
   I see, so the AccessChecker log access deny/allow at warn/info level may 
solve the log duplication problems?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org