[GitHub] [hbase] huaxiangsun commented on pull request #1734: HBASE-24376 MergeNormalizer is merging non-adjacent regions and causi…

2020-05-21 Thread GitBox 


huaxiangsun commented on pull request #1734:
URL: https://github.com/apache/hbase/pull/1734#issuecomment-632229515


   Thanks for the reviews!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] huaxiangsun commented on pull request #1734: HBASE-24376 MergeNormalizer is merging non-adjacent regions and causi…

2020-05-20 Thread GitBox 


huaxiangsun commented on pull request #1734:
URL: https://github.com/apache/hbase/pull/1734#issuecomment-631733381


   @ndimiduk @HorizonNet any comments/objection for me to merge the patch? 
Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] huaxiangsun commented on pull request #1734: HBASE-24376 MergeNormalizer is merging non-adjacent regions and causi…

2020-05-19 Thread GitBox 


huaxiangsun commented on pull request #1734:
URL: https://github.com/apache/hbase/pull/1734#issuecomment-630932274


   @virajjasani Yeah, the test is not flakey as it is mostly from 
testRegionNormalizationMergeOnCluster(), and that one never shows up in the 
flakey list. I will add more comments in 
tableRegions.sort(RegionInfo.COMPARATOR). Thanks for the review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org