[GitHub] [hbase] huaxiangsun commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-02 Thread GitBox


huaxiangsun commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-637699787


   +1 on the new udpate.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] huaxiangsun commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-06-01 Thread GitBox


huaxiangsun commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-637017304


   +1 for the new diff, looks great!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] huaxiangsun commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox


huaxiangsun commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-634951336


   diff --git 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
   index 6b75ed7881..eeb9bef0c8 100644
   --- 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
   +++ 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
   @@ -396,13 +396,13 @@ public class TestSimpleRegionNormalizer {
final byte[][] keys = {
  null,
  Bytes.toBytes("aa"),
   -  Bytes.toBytes("aa1"),
  Bytes.toBytes("aa1!"),
   +  Bytes.toBytes("aa1"),
  Bytes.toBytes("aa2"),
  null,
};
final List regionInfos = createRegionInfos(tableName, keys);
   -final Map regionSizes = 
createRegionSizesMap(regionInfos, 3, 1, 3, 1, 5);
   +final Map regionSizes = 
createRegionSizesMap(regionInfos, 3, 1, 1, 3, 5);
setupMocksForNormalizer(regionSizes, regionInfos);

// Compute the plan, no merge plan returned as they are not adjacent.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org