[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-09 Thread GitBox 


infraio commented on pull request #1935:
URL: https://github.com/apache/hbase/pull/1935#issuecomment-656437001


   > If I make a change only in MasterQuotaManager, other classes that call 
QuotaUtil.deleteNamespaceQuota() will not get the fix.
   
   Which class will call this? Clear all related table's quota is not the duty 
of QuotaUtil.deleteNamespaceQuota(). The upper layer should do this job, call 
deleteNamespaceQuota first then call deleteTableQuota. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-08 Thread GitBox 


infraio commented on pull request #1935:
URL: https://github.com/apache/hbase/pull/1935#issuecomment-655827442


   > My change removes these QUOTA_FAMILY_USAGE column family for the tables 
when a namespace quota is deleted and allows the user to insert into the tables 
in the namespace when the violated space quota is removed.
   
   Got it. But I thought you should fix the problem not in QuotaUtil class, 
maybe in MasterQuotaManager?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-05 Thread GitBox 


infraio commented on pull request #1935:
URL: https://github.com/apache/hbase/pull/1935#issuecomment-654028642


   > HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Namespace 
level
   > 
   > When a namespace space quota is deleted, the namespace quota (q:s) row 
from hbase:quota table is removed, however the related u:p rows from tables in 
the namespace still stay. Removing the u:p rows for tables in the namespace to 
fix this issue.
   
   How this fix related to the issue description?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org