[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions
javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-800204396 Mmmh I might have misunderstood the "localhost" mode. My intention is to be able to graceful_restart a local RegionServer in a secure environment where we can't use ssh to restart remotely. However, seems the localhost mode is actually meant to be used by pseudo-distributed mode: - https://issues.apache.org/jira/browse/HBASE-15924?focusedCommentId=16410243=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16410243 - https://issues.apache.org/jira/browse/HBASE-20130 And in `localhost` mode, `regionservers.sh` uses hard-coded ports: https://github.com/apache/hbase/blob/d74ae15fa7a110d3e2b35bf53d8823ba0b1bb33b/bin/regionservers.sh#L61-L64 This is very confusing, because if someone has configured other ports and restart in `localhost` mode, it will see the ports changing after the restart. Let me rethink about a proper solution or just leave the original proposed change https://github.com/apache/hbase/pull/2973 (pushed by @saintstack in this commit https://github.com/apache/hbase/commit/59ec375d679dcbf1701a92d4206ecc676a8fb069). So please don't merge this yet (I may close it an open with a new solution). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions
javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-800204396 Mmmh I might have misunderstood the "localhost" mode. My intention is to be able to graceful_restart a local RegionServer in a secure environment where we can't use ssh to restart remotely. However, seems the localhost mode is actually meant to be used by pseudo-distributed mode: - https://issues.apache.org/jira/browse/HBASE-15924?focusedCommentId=16410243=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16410243 - https://issues.apache.org/jira/browse/HBASE-20130 And in `localhost` mode, `regionservers.sh` uses hard-coded ports: https://github.com/apache/hbase/blob/d74ae15fa7a110d3e2b35bf53d8823ba0b1bb33b/bin/regionservers.sh#L61-L64 This is very confusing, because if someone has configured other ports and restart in localhost, it will see the ports changing. Let me rethink about a proper solution or just leave the original proposed change https://github.com/apache/hbase/pull/2973 (pushed by @saintstack in this commit https://github.com/apache/hbase/commit/59ec375d679dcbf1701a92d4206ecc676a8fb069). So please don't merge this yet (I may close it an open with a new solution). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions
javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit revives your previous changes. Second one addresses the commented issue with RegionMover. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions
javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit revives your previous changes. Second one is addressing the commented issue with RegionMover. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions
javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit is yours. Second one is addressing the commented issue with RegionMover. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
