[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present

2020-01-16 Thread GitBox
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category 
is present
URL: https://github.com/apache/hbase/pull/1052#issuecomment-575302082
 
 
   Awesomes, @bharathv ! I'll spin out a new Jira issue and mention you all 
there :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present

2020-01-16 Thread GitBox
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category 
is present
URL: https://github.com/apache/hbase/pull/1052#issuecomment-575271739
 
 
   ```
   % mvn -X
   Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
   Maven home: /usr/local/Cellar/maven/3.6.3/libexec
   Java version: 1.8.0_211, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk1.8.0_211.jdk/Contents/Home/jre
   Default locale: en_US, platform encoding: UTF-8
   OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac"
   ```
   
   maybe some difference in built tools, @ndimiduk ? That is goofy that you see 
something else.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present

2020-01-16 Thread GitBox
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category 
is present
URL: https://github.com/apache/hbase/pull/1052#issuecomment-575203674
 
 
   Thanks @busbey  and @virajjasani for the reviews as well! I didn't notice 
your approvals until after pushing (was going to push last night, but someone 
beat me to it and then I needed to rebase). Apologies for not getting your 
`Signed-off-by` in the commit message.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services