[GitHub] [hbase] lhofhansl commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-16 Thread GitBox 


lhofhansl commented on pull request #2075:
URL: https://github.com/apache/hbase/pull/2075#issuecomment-659553602


   Darn... It used the wrong (old) email in the commit. Oh well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] lhofhansl commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-16 Thread GitBox 


lhofhansl commented on pull request #2075:
URL: https://github.com/apache/hbase/pull/2075#issuecomment-659543608


   Alright going to merge in a few.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] lhofhansl commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-16 Thread GitBox 


lhofhansl commented on pull request #2075:
URL: https://github.com/apache/hbase/pull/2075#issuecomment-659516053


   Re: Checkstyle... The indentation of the entire block in StoreScanner. 
is wrong (5 instead of 4) happy to fix the entire block, but it'd be unrelated 
make the patch larger.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] lhofhansl commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-15 Thread GitBox 


lhofhansl commented on pull request #2075:
URL: https://github.com/apache/hbase/pull/2075#issuecomment-659076398


   In unit tests StoreScanner.store might be null. Fixed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org