[GitHub] [hbase] ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null checks and logging to misc set of tests
ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null checks and logging to misc set of tests URL: https://github.com/apache/hbase/pull/1147#discussion_r376672487 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanException.java ## @@ -74,6 +74,8 @@ private static volatile boolean DO_NOT_RETRY; + private static final int ROW_COUNT = 10; Review comment: > TestAsyncTableScanException use a define for row counts; count 100 instead of 1000 and see if helps You're off by an order of magnitude. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null checks and logging to misc set of tests
ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null checks and logging to misc set of tests URL: https://github.com/apache/hbase/pull/1147#discussion_r376672782 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanException.java ## @@ -74,6 +74,8 @@ private static volatile boolean DO_NOT_RETRY; + private static final int ROW_COUNT = 10; Review comment: Oh, you meant for the earlier test. Same question as @z-york asks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null checks and logging to misc set of tests
ndimiduk commented on a change in pull request #1147: HBASE-23814 Add null
checks and logging to misc set of tests
URL: https://github.com/apache/hbase/pull/1147#discussion_r376672667
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java
##
@@ -267,9 +267,10 @@ public void testZooKeeperAbort() throws Exception {
public void testZooKeeperNormal() throws Exception {
ReplicationLogCleaner cleaner = new ReplicationLogCleaner();
+long modTime = System.currentTimeMillis() - 1000;
Review comment:
> TestLogsCleaner use single mod time. Make it for sure less than now in
case test runs all in the same millisecond (would cause test fail)
Mind adding this note as a comment here in the test as well?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
