[GitHub] [hbase] ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to current version

2020-03-18 Thread GitBox 
ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to 
current version
URL: https://github.com/apache/hbase/pull/1253#issuecomment-600750333
 
 
   Thank you @HorizonNet !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to current version

2020-03-17 Thread GitBox 
ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to 
current version
URL: https://github.com/apache/hbase/pull/1253#issuecomment-600149401
 
 
   Unrelated to your patch, looks like the docker container failed to build.
   
   ```
   04:11:42   ---> Running in 87aed8f6e64b
   04:11:42  failed to get digest 
sha256:72300a873c2ca11c70d0c8642177ce76ff69ae04d61a5813ef58d40ff66e3e7c: open 
/var/lib/docker/image/overlay2/imagedb/content/sha256/72300a873c2ca11c70d0c8642177ce76ff69ae04d61a5813ef58d40ff66e3e7c:
 no such file or directory
   04:11:42  ERROR: Docker failed to build yetus/hbase:c088d2edc9.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to current version

2020-03-10 Thread GitBox 
ndimiduk commented on issue #1253: HBASE-23943 Updated Rubocop configuration to 
current version
URL: https://github.com/apache/hbase/pull/1253#issuecomment-597371581
 
 
   @HorizonNet the changes look good to me, not that I know anything about 
rubocop. To kick the build-bot into running the check, mind pushing a temporary 
change to one of the ruby files?
   
   @busbey how can we get yetus to run the rubocop check when the config file 
changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services