[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-603366345 I'm +1 with dropping this immediately from master. and Deprecating on all existing branch-2 release lines. This is not a class designed or intended for production use, only supporting the example. Let's include a release note about it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-603364688 > For me, example means you can copy the code, but not depend on the code That I agree with. Maybe we should discontinue publishing the hbase-examples jar to maven... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-602843351 Good find @Apache9 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…
ndimiduk commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M… URL: https://github.com/apache/hbase/pull/1323#issuecomment-602842867 * technically this needs a deprecation cycle. I'm okay with skipping it for this one though, since it's an unintentional part of our API, a class that (I imagine is) not heavily trafficked. * everything in `hbase-examples` should be `IA.Public`, right? * mind also update the javadoc to link off to `PBKeyValue` since it's now all in the same package? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
