[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

[GitBox]

ndimiduk commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-637734627


   Thanks for review everyone. Good discussion!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

[GitBox]

ndimiduk commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-635688358


   > Interesting. Wonder why the change was made.
   
   Looks like it was slipped in with 
https://issues.apache.org/jira/browse/HBASE-15065. There's some interesting 
comments as well from the original author in regard to the plan order, the move 
from a single global, optimized plan to the current list of actions ("plans").



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

[GitBox]

ndimiduk commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-634960241


   > Generally, I think the default is too aggressive.
   
   @saintstack Looks liked we originally ran the normalizer on a 30min period. 
This was reduced to 5 min for 2.0, according to 
https://hbase.apache.org/book.html#upgrade2.0.changed.defaults



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

[GitBox]

ndimiduk commented on pull request #1786:
URL: https://github.com/apache/hbase/pull/1786#issuecomment-634358652


   I intend to backport this at least to branch-2.3. I think branch-2.2 needs 
some other patches before this would apply.
   
   PTAL, @saintstack @Apache9 @infraio @huaxiangsun @joshelser @mnpoonia @ddupg.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org