[GitHub] [hbase] ndimiduk commented on pull request #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions

2022-06-09 Thread GitBox


ndimiduk commented on PR #4459:
URL: https://github.com/apache/hbase/pull/4459#issuecomment-1150971831

   I tracked down the broken test to 313a37f7ac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] ndimiduk commented on pull request #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions

2022-06-03 Thread GitBox


ndimiduk commented on PR #4459:
URL: https://github.com/apache/hbase/pull/4459#issuecomment-1146041985

   - rebased
   - decouple spawned thread spans from parent thread spans, just in case
   - ensure all manually-managed spans have a status set
   - rename/move test to better match its scope


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] ndimiduk commented on pull request #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions

2022-06-02 Thread GitBox


ndimiduk commented on PR #4459:
URL: https://github.com/apache/hbase/pull/4459#issuecomment-1144903579

   FYI I'm working through the branch-2 back-port and it's finding some other 
places I missed in this patch for master. Will be back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org