[GitHub] [hbase] risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

2019-11-25 Thread GitBox
risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs 
(HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#issuecomment-558196593
 
 
   @busbey @joshelser I think this is ready for another round of review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

2019-11-22 Thread GitBox
risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs 
(HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#issuecomment-557633285
 
 
   Latest push adds comment about deprecation handling and why not use Hadoop 
`Configuration` deprecation handling. Also fixes the license header to remove 
copyright.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

2019-11-19 Thread GitBox
risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs 
(HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#issuecomment-555656319
 
 
   Pushed whitespace fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

2019-11-19 Thread GitBox
risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs 
(HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#issuecomment-555631214
 
 
   Pushed change that addresses the license and race condition with the tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

2019-11-19 Thread GitBox
risdenk commented on issue #850: HBASE-23312 HBase Thrift SPNEGO configs 
(HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#issuecomment-555611094
 
 
   FYI @busbey @esteban @joshelser (I'm not sure how to tag reviewers or get 
feedback on the PR - doesn't look like the HBase book was updated? 
https://hbase.apache.org/book.html#submitting.patches). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services