[GitHub] [hbase] saintstack commented on a change in pull request #2801: HBASE-25433 There is no limit on the table name length when creating a table

[GitBox]

saintstack commented on a change in pull request #2801:
URL: https://github.com/apache/hbase/pull/2801#discussion_r572354056



##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
##
@@ -242,6 +255,9 @@ public static void isLegalNamespaceName(final byte[] 
namespaceName,
   // A znode named "zookeeper" is disallowed by zookeeper.
   throw new IllegalArgumentException("Tables may not be named '" + 
DISALLOWED_TABLE_NAME + "'");
 }
+if(namespaceName.length > MAX_NAMESPACE_LENGTH){

Review comment:
   Any update here @tomZou12 ? Thanks.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] saintstack commented on a change in pull request #2801: HBASE-25433 There is no limit on the table name length when creating a table

[GitBox]

saintstack commented on a change in pull request #2801:
URL: https://github.com/apache/hbase/pull/2801#discussion_r551034111



##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
##
@@ -242,6 +255,9 @@ public static void isLegalNamespaceName(final byte[] 
namespaceName,
   // A znode named "zookeeper" is disallowed by zookeeper.
   throw new IllegalArgumentException("Tables may not be named '" + 
DISALLOWED_TABLE_NAME + "'");
 }
+if(namespaceName.length > MAX_NAMESPACE_LENGTH){

Review comment:
   See background code. It has a space after the 'if' and before the '('.  
Ditto on end.
   
   Can you add a test for this nice addition? Thanks.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org