[GitHub] [hbase] shahrs87 commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-14 Thread GitBox


shahrs87 commented on pull request #1962:
URL: https://github.com/apache/hbase/pull/1962#issuecomment-658257865


   @virajjasani  could you please help review and commit this patch ? Thank you 
!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] shahrs87 commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-06 Thread GitBox


shahrs87 commented on pull request #1962:
URL: https://github.com/apache/hbase/pull/1962#issuecomment-654348836


   @WenFeiYi  Thank you for the PR. Mind writing a small test case for this. 
Overall the code looks good to me. Thank you !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org