[GitHub] [hbase] sunhelly commented on a diff in pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
sunhelly commented on code in PR #4403: URL: https://github.com/apache/hbase/pull/4403#discussion_r879023113 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -378,12 +381,18 @@ public class HMaster extends HBaseServerBase implements Maste private HbckChore hbckChore; CatalogJanitor catalogJanitorChore; - // Threadpool for scanning the archive directory, used by the HFileCleaner - private DirScanPool hfileCleanerPool; // Threadpool for scanning the Old logs directory, used by the LogCleaner private DirScanPool logCleanerPool; private LogCleaner logCleaner; - private HFileCleaner hfileCleaner; + // HFile cleaners for the custom hfile archive paths and the default archive path + // The archive path cleaner is the first element + private LinkedList hfileCleaners = new LinkedList<>(); Review Comment: Thanks, good suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on a diff in pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
sunhelly commented on code in PR #4403: URL: https://github.com/apache/hbase/pull/4403#discussion_r877490131 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -384,6 +387,9 @@ public class HMaster extends HBaseServerBase implements Maste private DirScanPool logCleanerPool; private LogCleaner logCleaner; private HFileCleaner hfileCleaner; + private HFileCleaner[] customHFileCleaners; + private Path[] customHFilePaths; + private DirScanPool customHFileCleanerPool; Review Comment: Thanks. All the custom paths cleaners use a shared DirScanPool, while the origin archive cleaner use an exclusive DirScanPool. I think currently it is not necessary for each custom path use its unique DirScanPool, since all the customs paths are subdirectories under the hfile archive path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on a diff in pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
sunhelly commented on code in PR #4403: URL: https://github.com/apache/hbase/pull/4403#discussion_r876970377 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -384,6 +387,9 @@ public class HMaster extends HBaseServerBase implements Maste private DirScanPool logCleanerPool; private LogCleaner logCleaner; private HFileCleaner hfileCleaner; + private HFileCleaner[] customHFileCleaners; Review Comment: Collected the hfileCleaner and customHFileCleaners to a linked list, and let the default hfileCleaner be the first element. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on a diff in pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
sunhelly commented on code in PR #4403: URL: https://github.com/apache/hbase/pull/4403#discussion_r876970377 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -384,6 +387,9 @@ public class HMaster extends HBaseServerBase implements Maste private DirScanPool logCleanerPool; private LogCleaner logCleaner; private HFileCleaner hfileCleaner; + private HFileCleaner[] customHFileCleaners; Review Comment: Collected the hfileCleaner and customHFileCleaners in a linked list, the head is the default hfileCleaner. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
