[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332759817 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: Here is what I changed it to in coming patch... " Do a server-side fix of bad or inconsistent state in hbase:meta. Available in hbase 2.2.1/2.1.6 or newer versions. Master UI has matching, new 'HBCK Report' tab that dumps reports generated by most recent run of _catalogjanitor_ and a new 'HBCK Chore'. It is critical that hbase:meta first be made healthy before making any other repairs. Fixes 'holes', 'overlaps', etc., creating (empty) region directories in HDFS to match regions added to hbase:meta. Command is NOT the same as the old _hbck1_ command named similarily. Works against the reports generated by the last catalog_janitor and hbck chore runs. If nothing to fix, run is a noop. Otherwise, if 'HBCK Report' UI reports problems, a run of fixMeta will clear up hbase:meta issues. See 'HBase HBCK' UI for how to generate new report. SEE ALSO: reportMissingRegionsInMeta" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332618564 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: Let me add a note that empty dirs are created in HDFS. Makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332349970 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: You are right in that it creates an empty region to match the hole or overlap found in hbase:meta. What it does not do is look around in hdfs to try and match hdfs content w/ the hole that is being plugged or moving data around in hdfs to fill the overlap. I think talking of HDFS side-effects when describing fixMeta will give the wrong impression, that we will be doing reconcile w/ HDFS content which we are explicitly not doing in this command. Not sure how better to say this boss. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332346970 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: There is no reporting apart from Master UI in hbase2. No equivalent tool. We'd have to write one for those older releases. It would be different though because the report would not be generated by the catalogjanitor but by a tool reading hbase:meta remote running the code we recently added to catalogjanitor. So, the fixMeta fixes holes and overlaps in meta. It does not fix holes and overlaps in HDFS -- intentionally. Idea is you'd fix meta then if any orphan data in HDFS, you'd ask HBase to adopt it using the bulk load tool to load it up (The filesystem command would note the orphan data/regions). Shout if I should add more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r331723331 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: Hmmm... This usage note needed a good bit more. See what you think of the latest @daisukebe ? Thanks boss. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r331344966 ## File path: hbase-hbck2/README.md ## @@ -20,32 +20,33 @@ _HBCK2_ is the repair tool for Apache HBase clusters. -Problems in operation are bugs. -The need for an _HBCK2_ fix is meant as workaround until the bug is fixed and -deployed in a new hbase version. +Problems in operation are bugs. The need for an _HBCK2_ fix +is meant as workaround until the bug is fixed and deployed +in a new hbase version. ## _HBCK2_ vs _hbck1_ HBCK2 is the successor to [hbck](https://hbase.apache.org/book.html#hbck.in.depth), the repair tool that shipped with _hbase-1.x_ (A.K.A _hbck1_). Use _HBCK2_ in place of _hbck1_ making repairs against hbase-2.x clusters. _hbck1_ should not be run against an hbase-2.x install. It may do damage. While _hbck1_ is still bundled inside hbase-2.x --- to minimize surprise -- it is deprecated, to be removed in _hbase-3.x_. It's +-- to minimize surprise -- it is deprecated, to be removed in _hbase-3.x_. Its write-facility (`-fix`) has been removed. It can report on the state of an hbase-2.x cluster but its assessments will be inaccurate since it does not understand the internal workings of an hbase-2.x. -_HBCK2_ does not work the way _hbck1_ used to. See the next section for how. +_HBCK2_ does not work the way _hbck1_ used to, even for the case where commands are +similarly named across the two versions. See the next section for how the tools +differ. ## Philosophy -_HBCK2_ performs a single discrete 'fix' task each time it is run. It does not presume +_HBCK2_ performs a single, discrete task each time it is run. It does not presume a tool can analyze all about the running cluster and then repair 'all problems' found as -_hbck1_ used suggest. _HBCK2_ is a tool that is more in the vein of -[`plumbing` than `porcelain`](https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain). +_hbck1_ used suggest. Review comment: True that it can do a few holes/overlaps behind the scene. True also that fixMeta is a single task. What should we do here? In old days hbck1 had one command to for fixing holes, another for overlaps. We don't want to expose all the little steps needed to fix meta I've seen case where you fix holes and overlaps and meta is still borked. hbck1 used to also run multiple times because it would only do adjacents. The hbck2 fixMeta does better than this. The multi-merge helps here along w/ some math to figure what to merge. It's more likely to fix all in the one pass. We'd like to get fixMeta to a place where it can run once and take care of it all whether holes, overlaps or anything else. May take some time though (smile). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r331344966 ## File path: hbase-hbck2/README.md ## @@ -20,32 +20,33 @@ _HBCK2_ is the repair tool for Apache HBase clusters. -Problems in operation are bugs. -The need for an _HBCK2_ fix is meant as workaround until the bug is fixed and -deployed in a new hbase version. +Problems in operation are bugs. The need for an _HBCK2_ fix +is meant as workaround until the bug is fixed and deployed +in a new hbase version. ## _HBCK2_ vs _hbck1_ HBCK2 is the successor to [hbck](https://hbase.apache.org/book.html#hbck.in.depth), the repair tool that shipped with _hbase-1.x_ (A.K.A _hbck1_). Use _HBCK2_ in place of _hbck1_ making repairs against hbase-2.x clusters. _hbck1_ should not be run against an hbase-2.x install. It may do damage. While _hbck1_ is still bundled inside hbase-2.x --- to minimize surprise -- it is deprecated, to be removed in _hbase-3.x_. It's +-- to minimize surprise -- it is deprecated, to be removed in _hbase-3.x_. Its write-facility (`-fix`) has been removed. It can report on the state of an hbase-2.x cluster but its assessments will be inaccurate since it does not understand the internal workings of an hbase-2.x. -_HBCK2_ does not work the way _hbck1_ used to. See the next section for how. +_HBCK2_ does not work the way _hbck1_ used to, even for the case where commands are +similarly named across the two versions. See the next section for how the tools +differ. ## Philosophy -_HBCK2_ performs a single discrete 'fix' task each time it is run. It does not presume +_HBCK2_ performs a single, discrete task each time it is run. It does not presume a tool can analyze all about the running cluster and then repair 'all problems' found as -_hbck1_ used suggest. _HBCK2_ is a tool that is more in the vein of -[`plumbing` than `porcelain`](https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain). +_hbck1_ used suggest. Review comment: True that it can do a few holes/overlaps behind the scene. True also that fixMeta is a single task. What should we do here? In old days hbck1 had one command to for fixing holes, another for overlaps. We don't want to expose all the little steps needed to fix meta I've seen case where you fix holes and overlaps and meta is still borked. hbck1 used to also run multiple times because it would only do adjacents. The hbck2 fixMeta does better than this using the multi-merge. Its more likely to fix all in the one pass. We'd like to get fixMeta to a place where it can run once and take care of it all. May take some time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
saintstack commented on a change in pull request #40: HBASE-23112 [hbase-operator-tools] fixMeta in hbck2 is porcelain, in … URL: https://github.com/apache/hbase-operator-tools/pull/40#discussion_r331345101 ## File path: hbase-hbck2/README.md ## @@ -159,7 +160,9 @@ Command: fixMeta Do a server-side fixing of bad or inconsistent state in hbase:meta. - Repairs 'holes' and 'overlaps' in hbase:meta. + Critical that hbase:meta is first made healthy before making any + other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the + _hbck1_ command named similarily. SEE ALSO: reportMissingRegionsInMeta Review comment: We can, at least in newer hbases where the holes and overlaps are listed in the UI hbck report. Let me add a note. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
