[jira] [Comment Edited] (HBASE-17762) Add logging to HBaseAdmin for user initiated tasks

2017-03-09 Thread Esteban Gutierrez (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903767#comment-15903767
 ] 

Esteban Gutierrez edited comment on HBASE-17762 at 3/9/17 8:13 PM:
---

Also, looks like the change is only affecting client side logging and I think 
we should have this in the server side too. One thing I've been considering too 
is that we should add an optional string to VersionInfo to provide additional 
information to identify the client  (think of something similar to use 
mapreduce.task.attempt.id to identify the clients in HDFS). If that sounds 
interesting for you guys I'd be happy to work in a patch for that.


was (Author: esteban):
Also, looks like the change is only affecting client side logging and I think 
we should have this in the server side too. One thing I've been considering too 
is that we should add an optional string to VersionInfo two provide additional 
information to identify the client  (think of something similar to use 
mapreduce.task.attempt.id to identify the clients in HDFS). If that sounds 
interesting for you guys I'd be happy to work in a patch for that.

> Add logging to HBaseAdmin for user initiated tasks
> --
>
> Key: HBASE-17762
> URL: https://issues.apache.org/jira/browse/HBASE-17762
> Project: HBase
>  Issue Type: Task
>Reporter: churro morales
>Assignee: churro morales
> Fix For: 2.0.0, 1.4.0, 0.98.25
>
> Attachments: HBASE-17762.patch, HBASE-17762.v1.patch
>
>
> Things like auditing a forced major compaction are really useful and right 
> now there is no logging when this is triggered.  Other actions may require 
> logging as well. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (HBASE-17762) Add logging to HBaseAdmin for user initiated tasks

2017-03-09 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903745#comment-15903745
 ] 

Andrew Purtell edited comment on HBASE-17762 at 3/9/17 7:55 PM:


I don't think the current patch is sufficient [~churromorales]. We want (at 
least):

- What action was initiated
- When was the action initiated
- On what was the action initiated (e.g. region)
- Where was the action initiated: suppose the logline will contain this 
information, everyone will have log4j formatting configured to include the 
server host in the logline
- Who initiated the action: effective user, client IP address

Bonus

- When the action completed and how long it took in this same logline (for 
convenience)


was (Author: apurtell):
I don't think the current patch is sufficient [~churromorales]. We want (at 
least):

- What action was initiated
- When was the action initiated
- Where was the action initiated: suppose the logline will contain this 
information, everyone will have log4j formatting configured to include the 
server host in the logline
- Who initiated the action: effective user, client IP address

Bonus

- When the action completed and how long it took in this same logline (for 
convenience)

> Add logging to HBaseAdmin for user initiated tasks
> --
>
> Key: HBASE-17762
> URL: https://issues.apache.org/jira/browse/HBASE-17762
> Project: HBase
>  Issue Type: Task
>Reporter: churro morales
>Assignee: churro morales
> Fix For: 2.0.0, 1.4.0, 0.98.25
>
> Attachments: HBASE-17762.patch, HBASE-17762.v1.patch
>
>
> Things like auditing a forced major compaction are really useful and right 
> now there is no logging when this is triggered.  Other actions may require 
> logging as well. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)