[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279484#comment-16279484
]
Appy edited comment on HBASE-19410 at 12/6/17 1:09 AM:
---
(probably better place for discussion because of wider visibility than RB)
bq. Appy Replied on RB, changing inheritence to composition can not be done in
one circle since HTU is IA.Public, and I do not think it is necessary to spend
too many times to polish an existing testing util. Just introduce a new one, as
the composition change on HTU will finally make you change lots of code, no
difference from a new testing util.
New testing tool will be lot of work for which we might not have enough time
(beta 1 is in <20 days). Also, creating new one every time we might want to
improve our testing framework might be a lot.
Also, going over ref guide, which bucket does testing classes falling into?
(http://hbase.apache.org/book.html#hbase.versioning.post10) Are they client API
or server API?
Maybe we can add another line to the matrix: Testing API compat - major No,
minor No, patch Yes.
Alternate suggestion (less preferred, above one is more general approach):
Mark HBTU with IS.Evolving so we can break compat between minor versions.
wdyt? [~stack] [~mdrob] [~elserj]
Either way, don't wait your patch on this thing. If other comments in RB are
addressed, get it in. This can be done in a separate jira.
was (Author: appy):
(probably better place for discussion because of wider visibility than RB)
bq. Appy Replied on RB, changing inheritence to composition can not be done in
one circle since HTU is IA.Public, and I do not think it is necessary to spend
too many times to polish an existing testing util. Just introduce a new one, as
the composition change on HTU will finally make you change lots of code, no
difference from a new testing util.
New testing tool will be lot of work for which we might not have enough time
(beta 1 is in <20 days). Also, creating new one every time we might want to
improve our testing framework might be a lot.
Also, going over ref guide, which bucket does testing classes falling into?
(http://hbase.apache.org/book.html#hbase.versioning.post10) Are they client API
or server API?
Maybe we can add another line to the matrix: Testing API compat - major No,
minor No, patch Yes.
Alternate suggestion (less preferred, above one is more general approach):
Mark HBTU with IS.Evolving so we can break compat between minor versions.
Either way, don't wait your patch on this thing. If other comments in RB are
addressed, get it in. This can be done in a separate jira.
> Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
> --
>
> Key: HBASE-19410
> URL: https://issues.apache.org/jira/browse/HBASE-19410
> Project: HBase
> Issue Type: Task
> Components: test, Zookeeper
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch,
> HBASE-19410.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
