[jira] [Comment Edited] (HBASE-20478) move import checks from hbaseanti to checkstyle
[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455636#comment-16455636 ] Mike Drob edited comment on HBASE-20478 at 4/27/18 1:37 AM: Checkstyle 7+ requires JDK 8+, so won't be able to backport such a fix to branch-1, AFAICT. v4: - update checkstyle version - update checkstyle plugin version - move the import checks from anti to checkstyle couldn't verify this locally because checkstyle doesn't run in the normal maven build anymore and for some reason test-patch was ignoring the checkstyle plugin for me (maybe related to HBASE-20467) edit: maybe i need dummy changes in other modules to get it picked up? was (Author: mdrob): Checkstyle 7+ requires JDK 8+, so won't be able to backport such a fix to branch-1, AFAICT. v4: - update checkstyle version - update checkstyle plugin version - move the import checks from anti to checkstyle couldn't verify this locally because checkstyle doesn't run in the normal maven build anymore and for some reason test-patch was ignoring the checkstyle plugin for me (maybe related to HBASE-20467) > move import checks from hbaseanti to checkstyle > --- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Minor > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch, > HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, > HBASE-anti-check.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20478) move import checks from hbaseanti to checkstyle
[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454672#comment-16454672 ] Sean Busbey edited comment on HBASE-20478 at 4/26/18 6:35 PM: -- let's pick one and use it as an addendum. you prefer patch or review? was (Author: busbey): let's pick one and use it an addendum. you prefer patch or review? > move import checks from hbaseanti to checkstyle > --- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Minor > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.WIP.2.patch, > HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, HBASE-anti-check.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20478) move import checks from hbaseanti to checkstyle
[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452595#comment-16452595 ] Mike Drob edited comment on HBASE-20478 at 4/25/18 4:34 PM: getting the treemap stuff into our error-prone ruleset was proving to be very difficult (dealing with generics is not intuitive at the compiler level), but the other changes are easy. I'll engage the error-prone community later this week the get help with the second part of this. meanwhile, first patch attached. was (Author: mdrob): getting the treemap stuff into our error-prone ruleset was proving to be very difficult (dealing with generics is not intuitive at the compiler level), but the other changes are easy. > move import checks from hbaseanti to checkstyle > --- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, > HBASE-20478.WIP.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
