[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-30 Thread Anoop Sam John (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858692#comment-13858692
 ] 

Anoop Sam John commented on HBASE-10224:


+1

 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-30 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858827#comment-13858827
 ] 

Ted Yu commented on HBASE-10224:


Integrated to trunk.

Thanks for the review, Anoop.

 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859219#comment-13859219
 ] 

Hudson commented on HBASE-10224:


FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #29 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/29/])
HBASE-10224 Account for empty line in search output (tedyu: rev 1554271)
* /hbase/trunk/dev-support/test-patch.sh
HBASE-10224 Line length check in test-patch.sh is broken (tedyu: rev 1554234)
* /hbase/trunk/dev-support/test-patch.sh


 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-30 Thread ramkrishna.s.vasudevan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859272#comment-13859272
 ] 

ramkrishna.s.vasudevan commented on HBASE-10224:


+1 . sorry for the late review.

 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859324#comment-13859324
 ] 

Hudson commented on HBASE-10224:


SUCCESS: Integrated in HBase-TRUNK #4770 (See 
[https://builds.apache.org/job/HBase-TRUNK/4770/])
HBASE-10224 Account for empty line in search output (tedyu: rev 1554271)
* /hbase/trunk/dev-support/test-patch.sh
HBASE-10224 Line length check in test-patch.sh is broken (tedyu: rev 1554234)
* /hbase/trunk/dev-support/test-patch.sh


 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10224) Line length check in test-patch.sh is broken

2013-12-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857253#comment-13857253
 ] 

Hadoop QA commented on HBASE-10224:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12620572/10176-v1.txt
  against trunk revision .
  ATTACHMENT ID: 12620572

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8288//console

This message is automatically generated.

 Line length check in test-patch.sh is broken
 

 Key: HBASE-10224
 URL: https://issues.apache.org/jira/browse/HBASE-10224
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10176-v1.txt


 Here is related code in the script:
 {code}
   MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
 ...
   ll=`echo $lines | wc -l`
   if [[ $ll -gt $MAX_LINE_LENGTH_PATCH ]]; then
 {code}
 Here was the result from dry run:
 {code}
 TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep ^+ | 
 grep -v ^@@ | grep -v ^+++ | grep -v import | grep -v 
 hbase.protobuf.generated | awk -v len=101 'length ($0)  len' | head -n 
 10`
 TYus-MacBook-Pro:m7 tyu$ ll=`echo $lines | wc -l`
 TYus-MacBook-Pro:m7 tyu$ echo $ll
 3
 TYus-MacBook-Pro:m7 tyu$ echo $lines
 + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, 
 succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = 
 val2, compare with val1, succeed (now value = val3) + // Test 
 CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed 
 (value still = val2)
 {code}
 The value of $ll should be compared with 0, not the value of 
 $MAX_LINE_LENGTH_PATCH



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)