[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859320#comment-13859320 ] Hudson commented on HBASE-10239: SUCCESS: Integrated in HBase-TRUNK #4770 (See [https://builds.apache.org/job/HBase-TRUNK/4770/]) HBASE-10239. Improve determinism and debugability of TestAccessController (apurtell: rev 1553718) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858280#comment-13858280 ] Andrew Purtell commented on HBASE-10239: If you want verifyAllowed to fail, then you need to return an empty list or throw an AccessDeniedException. Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858210#comment-13858210 ] Hudson commented on HBASE-10239: FAILURE: Integrated in HBase-0.98 #40 (See [https://builds.apache.org/job/HBase-0.98/40/]) HBASE-10239. Improve determinism and debugability of TestAccessController (apurtell: rev 1553719) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858229#comment-13858229 ] Hudson commented on HBASE-10239: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #27 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/27/]) HBASE-10239. Improve determinism and debugability of TestAccessController (apurtell: rev 1553718) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858270#comment-13858270 ] ramkrishna.s.vasudevan commented on HBASE-10239: What i meant was I was trying to verify a scenario and added a testcase and was using verifyAllowed to see if the test fails. Actually the test was intended not to return any result. But verifyAllowed passed the test. Hence I thought of adding a fail condition even if obj is null. Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857609#comment-13857609 ] Andrew Purtell commented on HBASE-10239: Thanks for the +1 Ram I will commit this a bit later. verifyAllowed checks that no exception is thrown and if and only if there is a result collection object it should also not be empty. verifyDenied checks that either an ADE is thrown or if and only if there is a result collection object it should be empty. Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857781#comment-13857781 ] Hudson commented on HBASE-10239: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #38 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/38/]) HBASE-10239. Improve determinism and debugability of TestAccessController (apurtell: rev 1553719) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[
https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857176#comment-13857176
]
Hadoop QA commented on HBASE-10239:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620556/10239.patch
against trunk revision .
ATTACHMENT ID: 12620556
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8286//console
This message is automatically generated.
Improve determinism and debugability of TestAccessController
Key: HBASE-10239
URL: https://issues.apache.org/jira/browse/HBASE-10239
Project: HBase
Issue Type: Improvement
Affects Versions: 0.98.0, 0.99.0
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Fix For: 0.98.0, 0.99.0
Attachments: 10239.patch, wip-10239.patch
Separate grant and revoke API invocations to static helper methods in
SecureTestUtils. Wait for permissions cache updates using a Predicate. Log
the API calls, state checks, and waits.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857295#comment-13857295 ] ramkrishna.s.vasudevan commented on HBASE-10239: Went thro the patch. Looks good to me. +1. The updateACL is needed for solving the issue in HBASE-6104? Improve determinism and debugability of TestAccessController Key: HBASE-10239 URL: https://issues.apache.org/jira/browse/HBASE-10239 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Attachments: 10239.patch, wip-10239.patch Separate grant and revoke API invocations to static helper methods in SecureTestUtils. Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and waits. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
[
https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857304#comment-13857304
]
ramkrishna.s.vasudevan commented on HBASE-10239:
One small concern,
In the verifyAllowed and verifyDenied we check
{code}
if (obj != null obj instanceof List?) {
{code}
But incase of verifyAllowed if the obj itself is null then we silently come out
of the method thinking it is success. But it should actually fail because in
the verifyAllowed we expect the result.
Improve determinism and debugability of TestAccessController
Key: HBASE-10239
URL: https://issues.apache.org/jira/browse/HBASE-10239
Project: HBase
Issue Type: Improvement
Affects Versions: 0.98.0, 0.99.0
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Fix For: 0.98.0, 0.99.0
Attachments: 10239.patch, wip-10239.patch
Separate grant and revoke API invocations to static helper methods in
SecureTestUtils. Wait for permissions cache updates using a Predicate. Log
the API calls, state checks, and waits.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
