[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[ https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867455#comment-13867455 ] Sergey Shelukhin commented on HBASE-10242: -- feedback from RB client-side mvcc tracking in scanners - Key: HBASE-10242 URL: https://issues.apache.org/jira/browse/HBASE-10242 Project: HBase Issue Type: Sub-task Components: HFile, regionserver, Scanners Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HBASE-10241.wip0.patch, HBASE-10242.01.patch, HBASE-10242.patch Scanners should be able to track mvcc read point and send it to server. This is a subtask, so server can use this mvcc as best it can, but doesn't actually have to guarantee it within the scope of this jira. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[
https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867494#comment-13867494
]
Hadoop QA commented on HBASE-10242:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622331/HBASE-10242.01.patch
against trunk revision .
ATTACHMENT ID: 12622331
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+/** See {@link #ClientScanner(Configuration, Scan, TableName,
HConnection, boolean, RpcRetryingCallerFactory)} */
+/** @deprecated Use {@link #ClientScanner(Configuration, Scan, TableName,
HConnection, boolean)} */
+ this(conf, scan, TableName.valueOf(tableName), connection, new
RpcRetryingCallerFactory(conf));
+ \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007results\030\005
\003(\0132\007.Resu +
+ new java.lang.String[] { Region, Scan, ScannerId,
NumberOfRows, CloseScanner, NextCallSeq, ClientSideMvcc, });
+ new java.lang.String[] { CellsPerResult, ScannerId,
MoreResults, Ttl, Results, ClientSideMvcc, });
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8381//console
This message is automatically generated.
client-side mvcc tracking in scanners
-
Key: HBASE-10242
URL: https://issues.apache.org/jira/browse/HBASE-10242
Project: HBase
Issue Type: Sub-task
Components: HFile, regionserver, Scanners
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10241.wip0.patch, HBASE-10242.01.patch,
HBASE-10242.patch
Scanners should be able to track mvcc read point and send it to server. This
is a subtask, so server can use this mvcc as best it can, but doesn't
actually have to guarantee it within the scope of this jira.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[ https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861730#comment-13861730 ] Sergey Shelukhin commented on HBASE-10242: -- https://reviews.apache.org/r/16609/ let me look at the failed test client-side mvcc tracking in scanners - Key: HBASE-10242 URL: https://issues.apache.org/jira/browse/HBASE-10242 Project: HBase Issue Type: Sub-task Components: HFile, regionserver, Scanners Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HBASE-10241.wip0.patch, HBASE-10242.patch Scanners should be able to track mvcc read point and send it to server. This is a subtask, so server can use this mvcc as best it can, but doesn't actually have to guarantee it within the scope of this jira. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[ https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861783#comment-13861783 ] Sergey Shelukhin commented on HBASE-10242: -- test failure appears to be due to my debug logging that I forgot to remove, test takes a long time as such and logging slows it down beyond timeout. So that will pass after update. I will update w/reaction to first round of comments :) client-side mvcc tracking in scanners - Key: HBASE-10242 URL: https://issues.apache.org/jira/browse/HBASE-10242 Project: HBase Issue Type: Sub-task Components: HFile, regionserver, Scanners Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HBASE-10241.wip0.patch, HBASE-10242.patch Scanners should be able to track mvcc read point and send it to server. This is a subtask, so server can use this mvcc as best it can, but doesn't actually have to guarantee it within the scope of this jira. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[ https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861138#comment-13861138 ] Enis Soztutar commented on HBASE-10242: --- Can you please put this in RB? client-side mvcc tracking in scanners - Key: HBASE-10242 URL: https://issues.apache.org/jira/browse/HBASE-10242 Project: HBase Issue Type: Sub-task Components: HFile, regionserver, Scanners Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HBASE-10241.wip0.patch, HBASE-10242.patch Scanners should be able to track mvcc read point and send it to server. This is a subtask, so server can use this mvcc as best it can, but doesn't actually have to guarantee it within the scope of this jira. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[
https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861169#comment-13861169
]
Hadoop QA commented on HBASE-10242:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621189/HBASE-10242.patch
against trunk revision .
ATTACHMENT ID: 12621189
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+/** See {@link #ClientScanner(Configuration, Scan, TableName,
HConnection, boolean, RpcRetryingCallerFactory)} */
+/** See {@link #ClientScanner(Configuration, Scan, TableName, HConnection,
boolean, RpcRetryingCallerFactory)} */
+/** @deprecated Use {@link #ClientScanner(Configuration, Scan, TableName,
HConnection, boolean, RpcRetryingCallerFactory)} */
+/** @deprecated Use {@link #ClientScanner(Configuration, Scan, TableName,
HConnection, boolean)} */
+ this(conf, scan, TableName.valueOf(tableName), connection, new
RpcRetryingCallerFactory(conf));
+ \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007results\030\005
\003(\0132\007.Resu +
+ new java.lang.String[] { Region, Scan, ScannerId,
NumberOfRows, CloseScanner, NextCallSeq, ClientSideMvcc, });
+ new java.lang.String[] { CellsPerResult, ScannerId,
MoreResults, Ttl, Results, ClientSideMvcc, });
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers.testEncodedSeeker(TestEncodedSeekers.java:124)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8322//console
This message is automatically generated.
client-side mvcc tracking in scanners
-
Key: HBASE-10242
URL: https://issues.apache.org/jira/browse/HBASE-10242
Project: HBase
Issue Type: Sub-task
Components: HFile, regionserver, Scanners
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10241.wip0.patch, HBASE-10242.patch
Scanners should be able to track mvcc read point and send it to server. This
is a subtask, so server can use this mvcc as best it can, but doesn't
actually have to guarantee it within the scope of this jira.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[
https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857925#comment-13857925
]
Hadoop QA commented on HBASE-10242:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620708/HBASE-10241.wip0.patch
against trunk revision .
ATTACHMENT ID: 12620708
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8294//console
This message is automatically generated.
client-side mvcc tracking in scanners
-
Key: HBASE-10242
URL: https://issues.apache.org/jira/browse/HBASE-10242
Project: HBase
Issue Type: Sub-task
Components: HFile, regionserver, Scanners
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10241.wip0.patch
Scanners should be able to track mvcc read point and send it to server. This
is a subtask, so server can use this mvcc as best it can, but doesn't
actually have to guarantee it within the scope of this jira.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10242) client-side mvcc tracking in scanners
[ https://issues.apache.org/jira/browse/HBASE-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857341#comment-13857341 ] Sergey Shelukhin commented on HBASE-10242: -- Problem (talking to myself): splits and merges. Actually quite a bit of a problem, because by default the scanner will lose consistency on these - it's a new region so new mvcc will be obtained; but the simple alternative (tracking them and reusing mvcc) is even worse, esp. for merge - for example, if the first region had much lower mvcc before merge because it came from different server, the second region data with its old high mvcc numbers could become invisible. Probably, when obtaining the first mvcc for the region, the scanner will have track it for key range, and re-use it across splits / separate requests for merges. Almost makes you wonder if getting mvccs in advance is worth it for consistent scanner - that would be one request to a few RSes (that hold the requisite regions). client-side mvcc tracking in scanners - Key: HBASE-10242 URL: https://issues.apache.org/jira/browse/HBASE-10242 Project: HBase Issue Type: Sub-task Components: HFile, regionserver, Scanners Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Scanners should be able to track mvcc read point and send it to server. This is a subtask, so server can use this mvcc as best it can, but doesn't actually have to guarantee it within the scope of this jira. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
