subject:"\[jira\] \[Commented\] \(HBASE\-10322\) Strip tags from KV while sending back to client on reads"

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-07-16 Thread Hudson (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064020#comment-14064020
]

Hudson commented on HBASE-10322:

FAILURE: Integrated in HBase-TRUNK #5313 (See
[https://builds.apache.org/job/HBase-TRUNK/5313/])
HBASE-10398 HBase book updates for Replication after HBASE-10322. (Misty)
(anoopsamjohn: rev da8f0a336d9a3b516fc1f5d33c462b1ef4996117)
* src/main/docbkx/book.xml
* src/main/docbkx/security.xml
* src/main/docbkx/ops_mgt.xml

Strip tags from KV while sending back to client on reads

Key: HBASE-10322
URL: https://issues.apache.org/jira/browse/HBASE-10322
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Blocker
Fix For: 0.98.0, 0.99.0

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_V6.patch, HBASE-10322_codec.patch

Right now we have some inconsistency wrt sending back tags on read. We do
this in scan when using Java client(Codec based cell block encoding). But
during a Get operation or when a pure PB based Scan comes we are not sending
back the tags. So any of the below fix we have to do
1. Send back tags in missing cases also. But sending back visibility
expression/ cell ACL is not correct.
2. Don't send back tags in any case. This will a problem when a tool like
ExportTool use the scan to export the table data. We will miss exporting the
cell visibility/ACL.
3. Send back tags based on some condition. It has to be per scan basis.
Simplest way is pass some kind of attribute in Scan which says whether to
send back tags or not. But believing some thing what scan specifies might not
be correct IMO. Then comes the way of checking the user who is doing the
scan. When a HBase super user doing the scan then only send back tags. So
when a case comes like Export Tool's the execution should happen from a super
user.
So IMO we should go with #3.
Patch coming soon.

--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-22 Thread Hudson (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878469#comment-13878469
]

Hudson commented on HBASE-10322:

SUCCESS: Integrated in HBase-TRUNK #4847 (See
[https://builds.apache.org/job/HBase-TRUNK/4847/])
HBASE-10322 Strip tags from KV while sending back to client on reads.
(anoopsamjohn: rev 1560265)
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionKey.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecV2.java
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java
*
/hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecV2.java
*
/hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecWithTags.java
*
/hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodecWithTags.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_V6.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878506#comment-13878506
 ] 

Hudson commented on HBASE-10322:


SUCCESS: Integrated in HBase-0.98 #101 (See 
[https://builds.apache.org/job/HBase-0.98/101/])
HBASE-10322 Strip tags from KV while sending back to client on reads. 
(anoopsamjohn: rev 1560266)
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionKey.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecV2.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecV2.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodecWithTags.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java


 Strip tags from KV while sending back to client on reads
 

 Key: HBASE-10322
 URL: https://issues.apache.org/jira/browse/HBASE-10322
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Blocker
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10322.patch, HBASE-10322_V2.patch, 
 HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch, 
 HBASE-10322_V6.patch, HBASE-10322_codec.patch


 Right now we have some inconsistency wrt sending back tags on read. We do 
 this in scan when using Java client(Codec based cell block encoding). But 
 during a Get operation or when a pure PB based Scan comes we are not sending 
 back the tags.  So any of the below fix we have to do
 1. Send back tags in missing cases also. But sending back visibility 
 expression/ cell ACL is not correct.
 2. Don't send back tags in any case. This will a problem when a tool like 
 ExportTool use the scan to export the table data. We will miss exporting the 
 cell visibility/ACL.
 3. Send back tags based on some condition. It has to be per scan basis. 
 Simplest way is pass some kind of attribute in Scan which says whether to 
 send back tags or not. But believing some thing what scan specifies might not 
 be correct IMO. Then comes the way of checking the user who is doing the 
 scan. When a HBase super user doing the scan then only send back tags. So 
 when a case comes like Export Tool's the execution should happen from a super 
 user.
 So IMO we should go with #3.
 Patch coming soon.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878559#comment-13878559
 ] 

Hudson commented on HBASE-10322:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #95 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/95/])
HBASE-10322 Strip tags from KV while sending back to client on reads. 
(anoopsamjohn: rev 1560266)
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionKey.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* 
/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecV2.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java
* 
/hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecV2.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecWithTags.java
* 
/hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodecWithTags.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* 
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
* 
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java


 Strip tags from KV while sending back to client on reads
 

 Key: HBASE-10322
 URL: https://issues.apache.org/jira/browse/HBASE-10322
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Blocker
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10322.patch, HBASE-10322_V2.patch, 
 HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch, 
 HBASE-10322_V6.patch, HBASE-10322_codec.patch


 Right now we have some inconsistency wrt sending back tags on read. We do 
 this in scan when using Java client(Codec based cell block encoding). But 
 during a Get operation or when a pure PB based Scan comes we are not sending 
 back the tags.  So any of the below fix we have to do
 1. Send back tags in missing cases also. But sending back visibility 
 expression/ cell ACL is not correct.
 2. Don't send back tags in any case. This will a problem when a tool like 
 ExportTool use the scan to export the table data. We will miss exporting the 
 cell visibility/ACL.
 3. Send back tags based on some condition. It has to be per scan basis. 
 Simplest way is pass some kind of attribute in Scan which says whether to 
 send back tags or not. But believing some thing what scan specifies might not 
 be correct IMO. Then comes the way of checking the user who is doing the 
 scan. When a HBase super user doing the scan then only send back tags. So 
 when a case comes like Export Tool's the execution should happen from a super 
 user.
 So IMO we should go with #3.
 Patch coming soon.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877417#comment-13877417
]

Hadoop QA commented on HBASE-10322:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624103/HBASE-10322_V4.patch
against trunk revision .
ATTACHMENT ID: 12624103

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 23 new
or modified tests.

{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.

{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.

{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.

{color:green}+1 core tests{color}. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8481//console

This message is automatically generated.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877651#comment-13877651
 ] 

Andrew Purtell commented on HBASE-10322:


bq. I'd be +1 on committing this in meantime.

+1 for commit of v5 as is. Thanks for seeing this through Anoop and Ram. 

Please add a release note about HConstants.REPLICATION_CODEC_CONF_KEY.

Fix the comment above this change on commit:
{noformat}
diff --git 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
index a612b18..305a76a 100644
--- hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
+++ hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
@@ -1300,7 +1300,7 @@ public class RpcClient {
   Codec getCodec() {
 // For NO CODEC, hbase.client.rpc.codec must be the empty string AND
 // hbase.client.default.rpc.codec -- because default is to do cell block 
encoding.
-String className = conf.get(hbase.client.rpc.codec, 
getDefaultCodec(this.conf));
+String className = conf.get(HConstants.RPC_CODEC_CONF_KEY, 
getDefaultCodec(this.conf));
 if (className == null || className.length() == 0) return null;
 try {
   return (Codec)Class.forName(className).newInstance();
{noformat}

bq. Andrew can make the call on whether to wait on test completion before 
RC'ing or not.

I'd really like a test if we get one in. Would have to be a LargeTest given it 
spins up two clusters. If it proves difficult then we can skip it. Or, if it 
flakes during RC testing, we can revert it for 0.98.1. Therefore it makes sense 
to me to do it as a follow up issue. 

Please also update the replication section of the manual to inform the user 
what HConstants.REPLICATION_CODEC_CONF_KEY does. We also need an update of the 
section talking about tags that setting HConstants.REPLICATION_CODEC_CONF_KEY 
to the tags-aware codec is required to replicate tags from one cluster to 
another. 

[~stack]: The security coprocessors use operation attributes to ship metadata 
to the server. The downside is you have to take care because all cells bundled 
in the op will get the same metadata and the server has to rewrite the incoming 
cells, but the upside is we don't care about any limitations we might have with 
tags on the client. We can make tags first class for 1.0. We will have to 
look at things like negotiating codecs on the connection at that time.

 Strip tags from KV while sending back to client on reads
 

 Key: HBASE-10322
 URL: https://issues.apache.org/jira/browse/HBASE-10322
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Blocker
 Fix For: 0.98.0, 0.99.0

 Attachments: HBASE-10322.patch, HBASE-10322_V2.patch, 
 HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch, 
 HBASE-10322_codec.patch


 Right now we have some inconsistency wrt sending back tags on read. We do 
 this in scan when using Java client(Codec based cell block encoding). But 
 during a Get operation or when a pure PB based Scan comes we are not sending 
 back the tags.  So any of the below fix we have to do
 1. Send back tags in missing cases also. But sending back visibility 
 expression/ cell ACL is not correct.
 2. Don't send back tags in any case. This will a problem when a tool like 
 ExportTool use the scan to export the table data. We will miss exporting the 
 cell visibility/ACL.
 3. Send back tags based on some condition. It has to be per scan basis. 
 Simplest way is pass some kind of attribute in Scan which says whether to 
 send back tags or not. But believing some thing what scan specifies might not 
 be correct IMO. Then comes the way of checking the user who is doing the 
 scan. When a HBase super user doing the scan then only send back tags. So 
 when a case comes like Export Tool's the execution should happen from a super 
 user.
 So IMO we should go with #3.
 Patch coming soon.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877659#comment-13877659
]

Andrew Purtell commented on HBASE-10322:

And if making tags first class we will have to look at thorny issues like
deciding what user is allowed to attach what tags or what user is allowed to
see what tags. There's a lot involved with it and I think we will end up
punting on it all, but we can save this discussion for the next JIRA

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Anoop Sam John (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877662#comment-13877662
]

Anoop Sam John commented on HBASE-10322:

bq.Would have to be a LargeTest given it spins up two clusters. If it proves
difficult then we can skip it.
Pls see TestReplicationWithTags in the patch

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877665#comment-13877665
]

Andrew Purtell commented on HBASE-10322:

bq. Pls see TestReplicationWithTags in the patch

Yes, can we split this out to a subtask and commit the rest now?

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877721#comment-13877721
]

Hadoop QA commented on HBASE-10322:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624161/HBASE-10322_V5.patch
against trunk revision .
ATTACHMENT ID: 12624161

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 23 new
or modified tests.

{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.

{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.

{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.

{color:green}+1 core tests{color}. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8483//console

This message is automatically generated.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread ramkrishna.s.vasudevan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878246#comment-13878246
]

ramkrishna.s.vasudevan commented on HBASE-10322:

+1 on V6. Thanks everyone for the active participation and bringing this to a
conclusion.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_V6.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878259#comment-13878259
]

Hadoop QA commented on HBASE-10322:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624263/HBASE-10322_V6.patch
against trunk revision .
ATTACHMENT ID: 12624263

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 21 new
or modified tests.

{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.

{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.

{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.

{color:green}+1 core tests{color}. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8486//console

This message is automatically generated.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_V6.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-21 Thread Anoop Sam John (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878356#comment-13878356
]

Anoop Sam John commented on HBASE-10322:

Committed to Trunk and 98.
Will file a jira for the book update and test as per Andy's suggestion.

Note : There is no difference btw V5 and V6 other than the latter removed a
test class. So the Findbugs warns might have come from other commits I guess.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_V4.patch, HBASE-10322_V5.patch,
HBASE-10322_V6.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Anoop Sam John (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876241#comment-13876241
]

Anoop Sam John commented on HBASE-10322:

Sorry for the confusion Lars
The final idea is that only super user can view tags. But the impl raised some
issues and we decided that we will not handle at this time. As of now for
0.98.0 we will make tags as serevr only thing. No user, even super user, will
be able to retrieve tags to client side. Am I making it clear now?

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876680#comment-13876680
]

Andrew Purtell commented on HBASE-10322:

Let's condense the dense walls of text above to a one line answer to the below
question if it is possible:

Can we have a tag-aware codec that can be configured by *only*
ReplicationSource and ReplicationSink for the RPC they do server-to-server
cross site?

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876697#comment-13876697
]

Andrew Purtell commented on HBASE-10322:

[~lhofhansl], [~stack], [~anoop.hbase], [~ram_krish]: Quick recap as I see it.
Security tags can be more sensitive than the cell itself. Users will share the
cells among each other. However, we don't want that sharing to also leak access
rules for the cell. That would be at best a violation of need to know. Also,
0.96 clients can't handle serializations that include tags. The easiest answer
is: RPC does not handle cell tags. We can thus avoid: negotiation, per-cell
access checks, per-cell rewrites (copies). However, that fails to address
replication, which uses the RPC code but must be able to replicate tags from a
0.98 source to another 0.98 sink. For replication, we need to hand RPC a codec
that is tag aware. Because 0.98 may be talking to 0.96, we can't do that by
default, we need a configuration setting for replication that tells it what RPC
codec to select when talking to the peer.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876701#comment-13876701
]

Andrew Purtell commented on HBASE-10322:

[~lhofhansl]: Instead of Export, make a snapshot and DistCp the HFiles. Instead
of Import, use the bulk import facility.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Lars Hofhansl (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876734#comment-13876734
]

Lars Hofhansl commented on HBASE-10322:
---

Good summary. (And I'm really just a bystander here.)
It's simplest to keep tag server-only unless there is a compelling argument to
do differently.
A compelling argument might eventually be that code outside of HBase needs to
check/manipulate tags.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876758#comment-13876758
]

stack commented on HBASE-10322:
---

Nice distillation. So, to 'solve' this issue for 0.98.0RC, we just need to
figure a means of allowing a user insert a particular codec when the client is
replicating. It does not even have to be 'on' in 0.98.0. in fact it is
better if is not 'on'. It just needs to be possible. Right?

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876828#comment-13876828
]

Andrew Purtell commented on HBASE-10322:

bq. So, to 'solve' this issue for 0.98.0RC, we just need to figure a means of
allowing a user insert a particular codec when the client is replicating. It
does not even have to be 'on' in 0.98.0. in fact it is better if is not
'on'. It just needs to be possible. Right?

Yes.

One more configuration variable (yeah...) named hbase.replication.rpc.codec
or some such, so the tag-aware codec can be separately set up by the source and
sink. Defaulting to the same codec we are using for RPC to be compatible with
0.96 clients.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876835#comment-13876835
]

Andrew Purtell commented on HBASE-10322:

bq. A compelling argument might eventually be that code outside of HBase needs
to check/manipulate tags.

This will be possible after my proposed change on this issue. Such code can
directly build HFiles (v3) containing tags, and submit them through the bulk
import facility. Likewise, if you copy out HFiles (v3) from a snapshot, they
will come over with tags included, which can be read by accessing the HFile
directly using the low level scanners. The security story is acceptable.
Accumulo has a similar hands-off approach to labels in bulk imported files, see
http://accumulo.apache.org/1.5/accumulo_user_manual.html#_security: This
constraint is not applied to bulk imported data, if this a concern then disable
the bulk import permission. Also we can trivially prevent unauthorized direct
access to HFiles by enabling encryption (HBASE-7544).

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Anoop Sam John (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877148#comment-13877148
]

Anoop Sam John commented on HBASE-10322:

bq.It does not even have to be 'on' in 0.98.0. in fact it is better if is
not 'on'. It just needs to be possible.
+1 for that. The interface Codec is marked InterfaceAudience.Private . Do we
have to change this marking now?

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread ramkrishna.s.vasudevan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877158#comment-13877158
]

ramkrishna.s.vasudevan commented on HBASE-10322:

+1 on the entire summary.
bq.+1 for that. The interface Codec is marked InterfaceAudience.Private . Do we
have to change this marking now?
[~anoop.hbase]
I think Stack meant it only in the replication context? May be am not getting
the intent correctly.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877180#comment-13877180
]

stack commented on HBASE-10322:
---

bq. The interface Codec is marked InterfaceAudience.Private . Do we have to
change this marking now?

I dont follow you Anoop. The Codec remains as is. You just need to be able to
configure the replication source to use a codec that ships tags (do you have
one?) rather than the default no tags (and the default for replication should
be no tags so it can replicate from 0.98 to 0.96).

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Anoop Sam John (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877187#comment-13877187
]

Anoop Sam John commented on HBASE-10322:

Got it Stack. We will provide codec that can handle tag.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877196#comment-13877196
]

stack commented on HBASE-10322:
---

If we remove tags from Put, how do tags make it into the system at all?

Patch seems fine. I see where the replication codec is being inserted. For
sure we know this works? We haven't forgot anything? There is no test for it.

Good stuff lads.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread ramkrishna.s.vasudevan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877208#comment-13877208
]

ramkrishna.s.vasudevan commented on HBASE-10322:

bq.If we remove tags from Put, how do tags make it into the system at all?
The agreement is that 0.98.0 will not support tags from client side. all tags
will be server side only. As ACL and Visibility does tags will be passed via
Operation Attributes and the respective CPs will take care.
If really user needs to add tags, then he has to write his own CP, pass tags
via Operation Attributes and use it. (This is ideally not easy for the user),
but as we have this stripping tags from server to clients using codec, we have
finalised on this. Thoughts? [~saint@gmail.com]

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread ramkrishna.s.vasudevan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877245#comment-13877245
]

ramkrishna.s.vasudevan commented on HBASE-10322:

I am +1 on patch. KeyValueCodecWithTags and CellcodecwithTags both would be
needed right? I think better. so +1.

Strip tags from KV while sending back to client on reads

Attachments: HBASE-10322.patch, HBASE-10322_V2.patch,
HBASE-10322_V3.patch, HBASE-10322_codec.patch

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads

2014-01-20 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877275#comment-13877275
]

Hadoop QA commented on HBASE-10322:
---

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624069/HBASE-10322_V3.patch
against trunk revision .
ATTACHMENT ID: 12624069