[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909196#comment-13909196
]
Hudson commented on HBASE-10392:
FAILURE: Integrated in HBase-TRUNK #4943 (See
[https://builds.apache.org/job/HBase-TRUNK/4943/])
HBASE-10392 Correct references to hbase.regionserver.global.memstore.upperLimit
(ndimiduk: rev 1570721)
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
* /hbase/trunk/src/main/docbkx/ops_mgt.xml
* /hbase/trunk/src/main/docbkx/performance.xml
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch, HBASE-10392.4.patch,
> HBASE-10392.5.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909145#comment-13909145
]
Hudson commented on HBASE-10392:
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #96 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/96/])
HBASE-10392 Correct references to hbase.regionserver.global.memstore.upperLimit
(ndimiduk: rev 1570721)
*
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
* /hbase/trunk/src/main/docbkx/ops_mgt.xml
* /hbase/trunk/src/main/docbkx/performance.xml
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch, HBASE-10392.4.patch,
> HBASE-10392.5.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907701#comment-13907701
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630162/HBASE-10392.5.patch
against trunk revision .
ATTACHMENT ID: 12630162
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8760//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch, HBASE-10392.4.patch,
> HBASE-10392.5.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882333#comment-13882333
]
Anoop Sam John commented on HBASE-10392:
LGTM
BTW
MemStoreFlusher
{code}
+String oldValue = c.get(MEMSTORE_SIZE_OLD_KEY);
+if (oldValue != null) {
+ LOG.warn(MEMSTORE_SIZE_OLD_KEY + " is deprecated by " +
MEMSTORE_SIZE_KEY);
+}
{code}
This addition may be not needed. Already we check and log warn in
HBaseConfiguration. Can avoid this duplicate log message.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch, HBASE-10392.4.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882168#comment-13882168
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625236/HBASE-10392.4.patch
against trunk revision .
ATTACHMENT ID: 12625236
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8523//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch, HBASE-10392.4.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882151#comment-13882151
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625234/HBASE-10392.3.patch
against trunk revision .
ATTACHMENT ID: 12625234
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8521//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch, HBASE-10392.3.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881329#comment-13881329
]
Anoop Sam John commented on HBASE-10392:
{code}
- float globalMemstoreLimit =
conf.getFloat("hbase.regionserver.global.memstore.upperLimit", 0.4f);
- int gml = (int)(globalMemstoreLimit * CONVERT_TO_PERCENTAGE);
+ float globalMemstoreSize =
conf.getFloat("hbase.regionserver.global.memstore.size", 0.4f);
+ int gml = (int)(globalMemstoreSize * CONVERT_TO_PERCENTAGE);
{code}
I was/am worried abt this change where we look at the new config alone. What
if a user configure hbase.regionserver.global.memstore.upperLimit (old) to 0.5
and HConstants.HFILE_BLOCK_CACHE_SIZE_KEY to 0.4 ? This check will not find
out that right?
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881260#comment-13881260
]
Nick Dimiduk commented on HBASE-10392:
--
I take lack of further commentary as lack of interest and acceptance of patch
:) Will commit later today.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880129#comment-13880129
]
Nick Dimiduk commented on HBASE-10392:
--
[~anoop.hbase] Let me correct the heap sizing checks in HeapMemoryManager as a
part of HBASE-10403, or perhaps after it. Maybe you can have a look at the
BucketCache's onheap implementation and see if it needs to provide any
additional metadata to be properly managed.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880115#comment-13880115
]
Andrew Purtell commented on HBASE-10392:
Ok :-)
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880102#comment-13880102
]
Nick Dimiduk commented on HBASE-10392:
--
[~apurtell] This is a small correction to check the correct configuration. Will
I disrupt your process if I bring this into 0.98 in the next hour?
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880105#comment-13880105
]
Nick Dimiduk commented on HBASE-10392:
--
Scratch that. HBASE-5349 was only applied to trunk. [~apurtell] kindly
disregard :)
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879122#comment-13879122
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624388/HBASE-10392.2.patch
against trunk revision .
ATTACHMENT ID: 12624388
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8498//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch,
> HBASE-10392.2.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878916#comment-13878916
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624378/HBASE-10392.1.patch
against trunk revision .
ATTACHMENT ID: 12624378
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-common: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[51,15]
sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1110,19]
sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1116,21]
sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:[1121,28]
sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java:[103,8]
cannot find symbol
--
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-common: Compilation failure
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more{code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8497//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878890#comment-13878890
]
Nick Dimiduk commented on HBASE-10392:
--
It might me better if HeapMemoryManager would concede the check to
HBaseConfiguration. Neither class are considering the presence of BucketCache
running in heap mode, which I intend to address in a different ticket.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878837#comment-13878837
]
Anoop Sam John commented on HBASE-10392:
In fact this check is duplicated at 2 places now. But HeapMemoryManager will
get initialized only when the auto tuning is ON.. Thinking whether we can
remove the check at HeapMemoryManager.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878827#comment-13878827
]
Nick Dimiduk commented on HBASE-10392:
--
Ah you're right. I missed the occurrence in MemStoreFlusher. Currently it
respects both the old and new parameter. Maybe we could continue respecting new
or old but print a warning if the old is used? I'll update the patch to do that
and we'll see what folks think.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878198#comment-13878198
]
Anoop Sam John commented on HBASE-10392:
Thanks for finding out this Nick! Sorry I missed
In other places where the new config is added, giving BC for the old config
also. So if old config alone is present then also this check should work
correctly right? We can handle that way?
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878133#comment-13878133
]
Hadoop QA commented on HBASE-10392:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624213/HBASE-10392.0.patch
against trunk revision .
ATTACHMENT ID: 12624213
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8484//console
This message is automatically generated.
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
[
https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877970#comment-13877970
]
stack commented on HBASE-10392:
---
lgtm
> Correct references to hbase.regionserver.global.memstore.upperLimit
> ---
>
> Key: HBASE-10392
> URL: https://issues.apache.org/jira/browse/HBASE-10392
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
> Fix For: 0.99.0
>
> Attachments: HBASE-10392.0.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to
> {{hbase.regionserver.global.memstore.upperLimit}} was missed. Clean those up
> to use the new {{hbase.regionserver.global.memstore.size}} instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
