[jira] [Commented] (HBASE-10397) Fix findbugs introduced from HBASE-9426

2014-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878607#comment-13878607
 ] 

Hadoop QA commented on HBASE-10397:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12624325/HBASE-10397.patch
  against trunk revision .
  ATTACHMENT ID: 12624325

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

{color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8496//console

This message is automatically generated.

 Fix findbugs introduced from HBASE-9426
 ---

 Key: HBASE-10397
 URL: https://issues.apache.org/jira/browse/HBASE-10397
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Minor
 Fix For: 0.99.0

 Attachments: HBASE-10397.patch


 Method org.apache.hadoop.hbase.client.HBaseAdmin.execProcedure(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator
 Method org.apache.hadoop.hbase.client.HBaseAdmin.isProcedureFinished(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10397) Fix findbugs introduced from HBASE-9426

2014-01-22 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878617#comment-13878617
 ] 

Ted Yu commented on HBASE-10397:


+1

 Fix findbugs introduced from HBASE-9426
 ---

 Key: HBASE-10397
 URL: https://issues.apache.org/jira/browse/HBASE-10397
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Minor
 Fix For: 0.99.0

 Attachments: HBASE-10397.patch


 Method org.apache.hadoop.hbase.client.HBaseAdmin.execProcedure(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator
 Method org.apache.hadoop.hbase.client.HBaseAdmin.isProcedureFinished(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10397) Fix findbugs introduced from HBASE-9426

2014-01-22 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878846#comment-13878846
 ] 

Jonathan Hsieh commented on HBASE-10397:


+1.  thanks!

 Fix findbugs introduced from HBASE-9426
 ---

 Key: HBASE-10397
 URL: https://issues.apache.org/jira/browse/HBASE-10397
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Minor
 Fix For: 0.99.0

 Attachments: HBASE-10397.patch


 Method org.apache.hadoop.hbase.client.HBaseAdmin.execProcedure(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator
 Method org.apache.hadoop.hbase.client.HBaseAdmin.isProcedureFinished(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10397) Fix findbugs introduced from HBASE-9426

2014-01-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879148#comment-13879148
 ] 

Hudson commented on HBASE-10397:


SUCCESS: Integrated in HBase-TRUNK #4849 (See 
[https://builds.apache.org/job/HBase-TRUNK/4849/])
HBASE-10397 Fix findbugs introduced from HBASE-9426. (anoopsamjohn: rev 1560427)
* 
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java


 Fix findbugs introduced from HBASE-9426
 ---

 Key: HBASE-10397
 URL: https://issues.apache.org/jira/browse/HBASE-10397
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Priority: Minor
 Fix For: 0.99.0

 Attachments: HBASE-10397.patch


 Method org.apache.hadoop.hbase.client.HBaseAdmin.execProcedure(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator
 Method org.apache.hadoop.hbase.client.HBaseAdmin.isProcedureFinished(String, 
 String, Map) makes inefficient use of keySet iterator instead of entrySet 
 iterator



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)