[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004452#comment-14004452
]
Lars Hofhansl commented on HBASE-10417:
---
Not at a computer right now... Is this an issue for 0.94 as well?
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004690#comment-14004690
]
Ted Yu commented on HBASE-10417:
The problem is in 0.94 as well.
Opened HBASE-11225 for backport.
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003887#comment-14003887
]
Hadoop QA commented on HBASE-10417:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645795/HBASE-10417.patch
against trunk revision .
ATTACHMENT ID: 12645795
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9553//console
This message is automatically generated.
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003909#comment-14003909
]
Gustavo Anatoly commented on HBASE-10417:
-
Thanks for review, Ted :)
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004324#comment-14004324
]
Hudson commented on HBASE-10417:
SUCCESS: Integrated in HBase-0.98 #309 (See
[https://builds.apache.org/job/HBase-0.98/309/])
HBASE-10417 index is not incremented in PutSortReducer#reduce() (Gustavo)
(tedyu: rev 1596380)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10417) index is not incremented in PutSortReducer#reduce()
[
https://issues.apache.org/jira/browse/HBASE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004384#comment-14004384
]
Hudson commented on HBASE-10417:
SUCCESS: Integrated in HBase-TRUNK #5135 (See
[https://builds.apache.org/job/HBase-TRUNK/5135/])
HBASE-10417 index is not incremented in PutSortReducer#reduce() (Gustavo)
(tedyu: rev 1596381)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java
index is not incremented in PutSortReducer#reduce()
---
Key: HBASE-10417
URL: https://issues.apache.org/jira/browse/HBASE-10417
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Gustavo Anatoly
Priority: Minor
Fix For: 0.99.0, 0.98.3
Attachments: HBASE-10417.patch
Starting at line 76:
{code}
int index = 0;
for (KeyValue kv : map) {
context.write(row, kv);
if (index 0 index % 100 == 0)
context.setStatus(Wrote + index);
{code}
index is a variable inside while loop that is never incremented.
The condition index 0 cannot be true.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
