[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918418#comment-13918418 ] Lars Hofhansl commented on HBASE-10514: --- ping :) Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Critical Fix For: 0.96.2, 0.94.18 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918422#comment-13918422 ] stack commented on HBASE-10514: --- Thanks [~lhofhansl] Pinging myself now. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Critical Fix For: 0.96.2, 0.94.18 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919042#comment-13919042 ] stack commented on HBASE-10514: --- Writing tests to demo the Bugs listed at head of HBASE-10466. We are messing up the heap calculation sizes on failed flush for sure. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Critical Fix For: 0.96.2, 0.94.18 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900714#comment-13900714 ] stack commented on HBASE-10514: --- We do not need HBASE-10464. I took a look. We spawn a thread to open regions. The open handler already has this check for stopping or stopped regionserver host before we add region to online regions list. We should be good. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.2, 0.94.17 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900838#comment-13900838 ] stack commented on HBASE-10514: --- I missed your comments lads. Yeah, don't need hbase-10464. I'm at 10466 now. Will report back. Had it as blocker for 0.96.2 only so I'd look at it. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Critical Fix For: 0.96.2, 0.94.18 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[
https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900841#comment-13900841
]
stack commented on HBASE-10514:
---
HBASE-10466 is different to HBASE-5568. As I read it, we could be carrying an
extra snapshot if failed flush. It does not look like it gets cleared flushed
out on subsequent flush calls. Instead we see:
{code}
if (!this.snapshot.isEmpty()) {
LOG.warn(Snapshot called again without clearing previous. +
Doing nothing. Another ongoing flush or did we fail last attempt?);
{code}
Will report back.
Forward port HBASE-10464 and HBASE-10466
Key: HBASE-10514
URL: https://issues.apache.org/jira/browse/HBASE-10514
Project: HBase
Issue Type: Bug
Reporter: stack
Assignee: stack
Priority: Critical
Fix For: 0.96.2, 0.94.18
Critical data loss issues that we need to ensure are not in branches beyond
0.89fb. Assigning myself.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899851#comment-13899851 ] stack commented on HBASE-10514: --- oops. fixed. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Critical Fix For: 0.96.2 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899916#comment-13899916 ] Andrew Purtell commented on HBASE-10514: These should go into 0.98.0 then too? No sense releasing something with available fixes for data loss bugs. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.2 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899988#comment-13899988 ] Lars Hofhansl commented on HBASE-10514: --- Whoa. Not good. Needs to be in 0.94 for sure. Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.2 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[
https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900042#comment-13900042
]
Lars Hofhansl commented on HBASE-10514:
---
Looks like we cover HBASE-10464 already (checked 0.94).
HRegionServer.openRegion(...) calls checkOpen() first, which checks
this.stopped || this.abortRequested. If anything we might need to add a check
for {{stopping}} there.
I am not sure I follow HBASE-10466 completely.
Forward port HBASE-10464 and HBASE-10466
Key: HBASE-10514
URL: https://issues.apache.org/jira/browse/HBASE-10514
Project: HBase
Issue Type: Bug
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.96.2, 0.94.17
Critical data loss issues that we need to ensure are not in branches beyond
0.89fb. Assigning myself.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900051#comment-13900051 ] ramkrishna.s.vasudevan commented on HBASE-10514: Is HBASE-10466 someway related to HBASE-5568? Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.2, 0.94.17 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10514) Forward port HBASE-10464 and HBASE-10466
[ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900055#comment-13900055 ] Lars Hofhansl commented on HBASE-10514: --- Looks similar indeed. I was having a quick look at the code in 0.94 and couldn't make out anything wrong with it, offhand (didn't post that before, because I did not want to look like idiot if I was wrong - and I might yet be wrong :) ) Forward port HBASE-10464 and HBASE-10466 Key: HBASE-10514 URL: https://issues.apache.org/jira/browse/HBASE-10514 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Priority: Blocker Fix For: 0.96.2, 0.94.17 Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
