[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905467#comment-13905467 ] Anoop Sam John commented on HBASE-10534: +1 Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906023#comment-13906023 ] Hudson commented on HBASE-10534: SUCCESS: Integrated in hbase-0.96 #303 (See [https://builds.apache.org/job/hbase-0.96/303/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569840) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906027#comment-13906027 ] Hudson commented on HBASE-10534: SUCCESS: Integrated in HBase-TRUNK #4933 (See [https://builds.apache.org/job/HBase-TRUNK/4933/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569837) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906046#comment-13906046 ] Lars Hofhansl commented on HBASE-10534: --- What about 0.94? Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906180#comment-13906180 ] Hudson commented on HBASE-10534: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #158 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/158/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569843) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906379#comment-13906379 ] Hudson commented on HBASE-10534: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #94 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/94/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569837) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906388#comment-13906388 ] Hudson commented on HBASE-10534: SUCCESS: Integrated in HBase-0.98 #171 (See [https://builds.apache.org/job/HBase-0.98/171/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569843) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906411#comment-13906411 ] Hudson commented on HBASE-10534: SUCCESS: Integrated in hbase-0.96-hadoop2 #209 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/209/]) HBASE-10534 Rowkey in TsvImporterTextMapper initializing with wrong length(Rajesh) (rajeshbabu: rev 1569840) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsvParser.java Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906604#comment-13906604 ] rajeshbabu commented on HBASE-10534: [~lhofhansl] This issue related to HBASE-8768(Improve bulkload performance) which is not available in 0.94. Can we backport HBASE-8768 to 0.94 as well? Thanks. Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906607#comment-13906607 ] Lars Hofhansl commented on HBASE-10534: --- Hmm... Maybe we should. Lemme look at that issue tomorrow. Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901464#comment-13901464 ] Hadoop QA commented on HBASE-10534: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629009/HBASE-10534.patch against trunk revision . ATTACHMENT ID: 12629009 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:354) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8699//console This message is automatically generated. Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10534) Rowkey in TsvImporterTextMapper initializing with wrong length
[ https://issues.apache.org/jira/browse/HBASE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13902035#comment-13902035 ] Ted Yu commented on HBASE-10534: +1 Rowkey in TsvImporterTextMapper initializing with wrong length -- Key: HBASE-10534 URL: https://issues.apache.org/jira/browse/HBASE-10534 Project: HBase Issue Type: Bug Components: mapreduce Affects Versions: 0.96.0 Reporter: rajeshbabu Assignee: rajeshbabu Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: HBASE-10534.patch In TsvImporterTextMapper rowkey initializing with wrong length. parser.parseRowKey give pair of start and end positions, so the rowkey length initialized with rowkey end position instead of length. {code} PairInteger,Integer rowKeyOffests = parser.parseRowKey(value.getBytes(), value.getLength()); ImmutableBytesWritable rowKey = new ImmutableBytesWritable( value.getBytes(), rowKeyOffests.getFirst(), rowKeyOffests.getSecond()); {code} Its better to change TsvParser#parseRowKey to return starting position and length of rowkey. -- This message was sent by Atlassian JIRA (v6.1.5#6160)