[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956779#comment-13956779
]
stack commented on HBASE-10867:
---
+1
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt, 10867.addendum
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956756#comment-13956756
]
stack commented on HBASE-10867:
---
That makes sense. Thanks. I missed [~liushaohui]'s comment (was focused on
your remarks looking for explanation...)
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956743#comment-13956743
]
Ted Yu commented on HBASE-10867:
In trunk, if you place a breakpoint at the second assignment below:
{code}
ServerName servers[] = oldStatus.getServers().toArray(new ServerName[10]);
ServerName serverToKill = null;
{code}
You can see that servers array is of size 11.
Previously the size was of 10.
As Shaohui pointed out:
bq. the Master is also a RegionServer since HBASE-10569
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956731#comment-13956731
]
stack commented on HBASE-10867:
---
bq. In 0.98 and prior releases, servers[] is of size 10.
I don't follow. I see servers set to 10 in all versions.
In 0.98:
private final static int SLAVES = 10;
...
TEST_UTIL.startMiniCluster(SLAVES);
ServerName servers[] = oldStatus.getServers().toArray(new ServerName[10]);
ServerName serverToKill = null;
int killIndex = 0;
Random random = new Random(System.currentTimeMillis());
ServerName metaServer = TEST_UTIL.getHBaseCluster().getServerHoldingMeta();
LOG.debug("Server holding meta " + metaServer);
boolean isNamespaceServer = false;
do {
// kill a random non-meta server carrying at least one region
killIndex = random.nextInt(servers.length);
In trunk the same.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956705#comment-13956705
]
Ted Yu commented on HBASE-10867:
In 0.98 and prior releases, servers[] is of size 10.
So there is no chance of encountering ArrayIndexOutOfBoundsException.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956153#comment-13956153
]
Hudson commented on HBASE-10867:
FAILURE: Integrated in HBase-TRUNK #5053 (See
[https://builds.apache.org/job/HBase-TRUNK/5053/])
HBASE-10867 TestRegionPlacement#testRegionPlacement occasionally fails (tedyu:
rev 1583515)
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956109#comment-13956109
]
stack commented on HBASE-10867:
---
[~ted_yu] Why not apply this to 0.98, 0.96?
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956094#comment-13956094
]
stack commented on HBASE-10867:
---
Hmm... Looks like Ted already committed. This is what I'd remove:
{code}
Index:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
===
---
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
(revision 1583526)
+++
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
(working copy)
@@ -289,8 +289,6 @@
private void killRandomServerAndVerifyAssignment()
throws IOException, InterruptedException, KeeperException {
-ClusterStatus oldStatus = TEST_UTIL.getHBaseCluster().getClusterStatus();
-ServerName servers[] = oldStatus.getServers().toArray(new ServerName[10]);
ServerName serverToKill = null;
int killIndex = 0;
Random random = new Random(System.currentTimeMillis());
{code}
... but this test does not behave well for me locally. I am afraid to touch it.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956081#comment-13956081
]
stack commented on HBASE-10867:
---
Just ran into this:
https://builds.apache.org/job/PreCommit-HBASE-Build/9142//testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
over in HBASE-10855
Replacing server.length wtih SLAVES should work...If we do that though, then
there is a bunch of stuff to remove. Let me apply a patch that does what this
patch does AND the cleanup.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956006#comment-13956006
]
Liu Shaohui commented on HBASE-10867:
-
LGTM. Thanks, [~yuzhih...@gmail.com]
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955577#comment-13955577
]
Hadoop QA commented on HBASE-10867:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12637872/10867-v2.txt
against trunk revision .
ATTACHMENT ID: 12637872
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9141//console
This message is automatically generated.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955345#comment-13955345
]
Ted Yu commented on HBASE-10867:
Previously servers.length was 10, hence no ArrayIndexOutOfBoundsException.
Patch v2 uses constant SLAVES so that the index would be within bounds.
Further change can be done in separate JIRA.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 10867-v1.txt, 10867-v2.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954583#comment-13954583
]
Liu Shaohui commented on HBASE-10867:
-
[~yuzhih...@gmail.com]
The patch does fix the failed test. But, the root cause of the issue is that
the Master is also a RegionServer since HBASE-10569.
So the servers.length will be 11 and larger than the SLAVES:10 in the test.
{code}
killIndex = random.nextInt(servers.length);
{code}
What about making the MiniHBaseCluster adjust to HBASE-10569?
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 10867-v1.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10867) TestRegionPlacement#testRegionPlacement occasionally fails
[
https://issues.apache.org/jira/browse/HBASE-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951557#comment-13951557
]
Hadoop QA commented on HBASE-10867:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12637551/10867-v1.txt
against trunk revision .
ATTACHMENT ID: 12637551
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9130//console
This message is automatically generated.
> TestRegionPlacement#testRegionPlacement occasionally fails
> --
>
> Key: HBASE-10867
> URL: https://issues.apache.org/jira/browse/HBASE-10867
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 10867-v1.txt
>
>
> From
> https://builds.apache.org/job/HBase-TRUNK/5047/testReport/org.apache.hadoop.hbase.master/TestRegionPlacement/testRegionPlacement/
> :
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 10
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:368)
> at
> java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:377)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.getRegionServer(LocalHBaseCluster.java:224)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.getRegionServer(MiniHBaseCluster.java:609)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.killRandomServerAndVerifyAssignment(TestRegionPlacement.java:303)
> at
> org.apache.hadoop.hbase.master.TestRegionPlacement.testRegionPlacement(TestRegionPlacement.java:270)
> {code}
> In the setup:
> {code}
> TEST_UTIL.startMiniCluster(SLAVES);
> {code}
> where SLAVES is 10.
> So when 10 was used in
> TEST_UTIL.getHBaseCluster().getRegionServer(killIndex), we would get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
