[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302940#comment-14302940 ] Hudson commented on HBASE-10942: FAILURE: Integrated in HBase-TRUNK #6080 (See [https://builds.apache.org/job/HBase-TRUNK/6080/]) HBASE-10942. support parallel request cancellation for multi-get (Nicolas Liochon Devaraj Das) (ddas: rev cf5ad96fcc2ac02889e8a96a5d99cac071e1f25c) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Devaraj Das Fix For: 1.1.0 Attachments: 10942-1.1.txt, 10942-branch-1.txt, 10942-for-98.zip, 10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302975#comment-14302975 ] Hudson commented on HBASE-10942: FAILURE: Integrated in HBase-1.1 #134 (See [https://builds.apache.org/job/HBase-1.1/134/]) HBASE-10942. support parallel request cancellation for multi-get (Nicolas Liochon Devaraj Das) (ddas: rev 44596148c7b433f9db5288a0e776365d9bab1fad) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Devaraj Das Fix For: 1.1.0 Attachments: 10942-1.1.txt, 10942-branch-1.txt, 10942-for-98.zip, 10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302028#comment-14302028 ] Nicolas Liochon commented on HBASE-10942: - Time goes by ;-) LGTM, +1 support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Nicolas Liochon Fix For: hbase-10070 Attachments: 10942-1.1.txt, 10942-for-98.zip, 10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302612#comment-14302612 ] Nick Dimiduk commented on HBASE-10942: -- Patch looks good to me. +1 ... though which branch is this intended for? I thought 10070 branch was dead. The file name contains 1.1, so does that mean branch-1? Would be good to get branch-specific HadoopQA output for each target branch for this patch. support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Nicolas Liochon Fix For: hbase-10070 Attachments: 10942-1.1.txt, 10942-for-98.zip, 10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[
https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302718#comment-14302718
]
Hadoop QA commented on HBASE-10942:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12696072/10942-branch-1.txt
against branch-1 branch at commit fef78acf6534f6736c10d2054cf8cb479edd3291.
ATTACHMENT ID: 12696072
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
12 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12673//console
This message is automatically generated.
support parallel request cancellation for multi-get
---
Key: HBASE-10942
URL: https://issues.apache.org/jira/browse/HBASE-10942
Project: HBase
Issue Type: Sub-task
Reporter: Sergey Shelukhin
Assignee: Nicolas Liochon
Fix For: hbase-10070
Attachments: 10942-1.1.txt, 10942-branch-1.txt, 10942-for-98.zip,
10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[
https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299562#comment-14299562
]
Hadoop QA commented on HBASE-10942:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695655/10942-1.1.txt
against master branch at commit b08802a3e8e522f84519415b83455870b49bf8da.
ATTACHMENT ID: 12695655
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12653//console
This message is automatically generated.
support parallel request cancellation for multi-get
---
Key: HBASE-10942
URL: https://issues.apache.org/jira/browse/HBASE-10942
Project: HBase
Issue Type: Sub-task
Reporter: Sergey Shelukhin
Assignee: Nicolas Liochon
Fix For: hbase-10070
Attachments: 10942-1.1.txt, 10942-for-98.zip, 10942.patch,
HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[
https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112411#comment-14112411
]
Hadoop QA commented on HBASE-10942:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12664655/10942.patch
against trunk revision .
ATTACHMENT ID: 12664655
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestAtomicOperation.testRowMutationMultiThreads(TestAtomicOperation.java:392)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10608//console
This message is automatically generated.
support parallel request cancellation for multi-get
---
Key: HBASE-10942
URL: https://issues.apache.org/jira/browse/HBASE-10942
Project: HBase
Issue Type: Sub-task
Reporter: Sergey Shelukhin
Assignee: Nicolas Liochon
Fix For: hbase-10070
Attachments: 10942.patch, HBASE-10942.01.patch, HBASE-10942.02.patch,
HBASE-10942.patch
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[
https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993680#comment-13993680
]
Nicolas Liochon commented on HBASE-10942:
-
Unrelated to this patch, but related to multiget replica
{code}
In AsyncProcess#receiveGlobalFailure
if (firstAction) { // == always false
firstAction = false;
isReplica =
!RegionReplicaUtil.isDefaultReplica(action.getReplicaId());
}
// [...]
//isReplica is always false here
if (toReplay.isEmpty()) {
logNoResubmit(server, numAttempt, rsActions.size(), t, isReplica,
failed, stopped);
} else {
resubmit(server, toReplay, numAttempt, rsActions.size(), t, isReplica,
selfTi);
}
{code}
{code}
AsyncProcess#receiveMultiAction
Same as AsyncProcess#receiveGlobalFailure
{code}
Nits:
bq. if (0 == ti.actionCount) {
yoda style spotted :-)
bq. if (e instanceof InterruptedIOException (validateInterrupt() == null))
return;
Either it's very smart, either it's wrong, as a SocketTimeoutException is a
IIOE. ExceptionUtil contains a method to check a Throwable.
bq. // If we use interruption, we'll have to pre-create the syncronization
structure
Typo on syncronization
bq. validateInterrupt
I don't really understand what this method is doing. Some comments would be
great.
bq. private void groupAndSendMultiAction(ListActionRow currentActions,
int numAttempt, ThreadInfo selfTi) {
The javadoc should be updated here.
Not nit:
I think that useInterrupt should not be an option. It doubles the test cases,
and it's not consistent with the simple get code.
The code is quite complex. Removing useInterruption will make it a little
simpler. I'm not sure it will be enough to make it reasonably easy to
understand There is as well some confusion between the Threads and and the
future: we're cancelling tasks, not killing threads. I tend to think that it
would be easier to read with a specific CompletionService?
support parallel request cancellation for multi-get
---
Key: HBASE-10942
URL: https://issues.apache.org/jira/browse/HBASE-10942
Project: HBase
Issue Type: Sub-task
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: hbase-10070
Attachments: HBASE-10942.01.patch, HBASE-10942.patch
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997828#comment-13997828 ] Nicolas Liochon commented on HBASE-10942: - bq. 1. We're not gonna agree on this :-). As we are only two, we can't have a vote. Let's try to bring a third party? It's not key per se, but simplifying the code is important here I think. bq. 2. It's the code related to ThreadInfo that could be moved (the BoundedCompletionService has a cancelAll function). I'm not saying it's trivial (hopefully it's possible!), but here as well I'm trying to have some simpler code in AsyncProcess. support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996449#comment-13996449 ] Nicolas Liochon commented on HBASE-10942: - bq. I think it's important to have way to turn off any new feature in case there's a bug in it... Yep, but the fact that the first code path does not work does not mean that the second one works better :-). Especially in this case, there are some nasty impacts if the threads are not interrupted. bq. What do you mean by having CompletionService i.e. what would we use it for It would allow to put the thread management code in another class (like the code for the simple get case, a much simpler case, I agree). support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996636#comment-13996636 ] Sergey Shelukhin commented on HBASE-10942: -- 1 - but it reduces the surface area. There's very little change to path when this feature is disabled... I've been burned by this in various distributed systems, most recently Hive (which is much easier to upgrade) 2 - can you give example? What code would be possible to move? We can move it. It uses thread pool right now... support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.02.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995613#comment-13995613 ] Sergey Shelukhin commented on HBASE-10942: -- isReplica there is only used for logging; fixed. Will fix rest and update the patch support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995631#comment-13995631 ] Sergey Shelukhin commented on HBASE-10942: -- About config - I think it's important to have way to turn off any new feature in case there's a bug in it... otherwise making new build and redeploying a cluster can be very costly for whoever is maintaining it. Wrt confusion, I'll rename variables. What do you mean by having CompletionService i.e. what would we use it for support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986223#comment-13986223 ] Enis Soztutar commented on HBASE-10942: --- [~nkeywal] it seems that this is your area of expertise. support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986301#comment-13986301 ] Sergey Shelukhin commented on HBASE-10942: -- yeah ping? support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: hbase-10070 Attachments: HBASE-10942.01.patch, HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10942) support parallel request cancellation for multi-get
[ https://issues.apache.org/jira/browse/HBASE-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13963730#comment-13963730 ] Sergey Shelukhin commented on HBASE-10942: -- [~enis] [~devaraj] fyi support parallel request cancellation for multi-get --- Key: HBASE-10942 URL: https://issues.apache.org/jira/browse/HBASE-10942 Project: HBase Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HBASE-10942.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
