[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[ https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103509#comment-14103509 ] Hudson commented on HBASE-11185: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #433 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/433/]) HBASE-11742 (Backport HBASE-7987 and HBASE-11185 to 0.98) (Esteban Gutierrez and Matteo Bertozzi) (apurtell: rev 2e978a165481c45c6a3d97b185c797a0425ddc44) * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ReferenceRegionHFilesTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotLogSplitter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestWALReferenceTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV1.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SnapshotProtos.java * hbase-protocol/src/main/protobuf/MapReduce.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotReferenceUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotLogCleaner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * hbase-common/src/main/resources/hbase-default.xml * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/Reference.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotLogSplitter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotDescriptionUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSnapshotInputFormat.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/MasterSnapshotVerifier.java * hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ProcedureManager.java * hbase-protocol/src/main/protobuf/Snapshot.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CopyRecoveredEditsTask.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ReferenceServerWALsTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestReferenceRegionHFilesTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestCopyRecoveredEditsTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java *
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[ https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103608#comment-14103608 ] Hudson commented on HBASE-11185: FAILURE: Integrated in HBase-0.98 #460 (See [https://builds.apache.org/job/HBase-0.98/460/]) HBASE-11742 (Backport HBASE-7987 and HBASE-11185 to 0.98) (Esteban Gutierrez and Matteo Bertozzi) (apurtell: rev 2e978a165481c45c6a3d97b185c797a0425ddc44) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV1.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSnapshotInputFormat.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TableInfoCopyTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotLogSplitter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ReferenceServerWALsTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotReferenceUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/Reference.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotDescriptionUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CopyRecoveredEditsTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotLogSplitter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SnapshotProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/EnabledTableSnapshotHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotLogCleaner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java * hbase-protocol/src/main/protobuf/Snapshot.proto * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestReferenceRegionHFilesTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestCopyRecoveredEditsTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java * hbase-protocol/src/main/protobuf/MapReduce.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotTask.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestWALReferenceTask.java * hbase-common/src/main/resources/hbase-default.xml *
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[ https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004393#comment-14004393 ] Hudson commented on HBASE-11185: SUCCESS: Integrated in HBase-TRUNK #5135 (See [https://builds.apache.org/job/HBase-TRUNK/5135/]) HBASE-11185 Parallelize Snapshot operations (mbertozzi: rev 1596168) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/MasterSnapshotVerifier.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV2.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotReferenceUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java Parallelize Snapshot operations --- Key: HBASE-11185 URL: https://issues.apache.org/jira/browse/HBASE-11185 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.99.0 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-11185-v0.patch when SnapshotInfo or snapshot verification is executed against a remote path, it may takes a while since all the code is mainly composed by sequential calls to the fs. This patch will parallelize all the snapshot operations using a thread pool to dispatch requests. The size of the pool is tunable by using hbase.snapshot.thread.pool.max -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[ https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000169#comment-14000169 ] stack commented on HBASE-11185: --- We don't need this anymore? visitRegionStoreFiles? It is done by verifySnapshot instead now? Whats up w/ alll the javadoc warnings? - /** + /**© Patch looks like nice speedup. +1 after fixing any javadoc warnings that are yours. ? Parallelize Snapshot operations --- Key: HBASE-11185 URL: https://issues.apache.org/jira/browse/HBASE-11185 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.99.0 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-11185-v0.patch when SnapshotInfo or snapshot verification is executed against a remote path, it may takes a while since all the code is mainly composed by sequential calls to the fs. This patch will parallelize all the snapshot operations using a thread pool to dispatch requests. The size of the pool is tunable by using hbase.snapshot.thread.pool.max -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[
https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000181#comment-14000181
]
Matteo Bertozzi commented on HBASE-11185:
-
{quote}We don't need this anymore? visitRegionStoreFiles It is done by
verifySnapshot instead now?{quote}
yeah, verifySnapshot is used instead.
{quote}Whats up w/ alll the javadoc warnings?{quote}
the javadoc warn are your fault :) HBASE-11171 More doc improvements on block
cache options the HFile ref is not found
Parallelize Snapshot operations
---
Key: HBASE-11185
URL: https://issues.apache.org/jira/browse/HBASE-11185
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.99.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE-11185-v0.patch
when SnapshotInfo or snapshot verification is executed against a remote path,
it may takes a while since all the code is mainly composed by sequential
calls to the fs.
This patch will parallelize all the snapshot operations using a thread pool
to dispatch requests. The size of the pool is tunable by using
hbase.snapshot.thread.pool.max
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[ https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000285#comment-14000285 ] stack commented on HBASE-11185: --- bq. the javadoc warn are your fault HBASE-11171 More doc improvements on block cache options the HFile ref is not found Duh. Fixing Parallelize Snapshot operations --- Key: HBASE-11185 URL: https://issues.apache.org/jira/browse/HBASE-11185 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 0.99.0 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Priority: Minor Fix For: 0.99.0 Attachments: HBASE-11185-v0.patch when SnapshotInfo or snapshot verification is executed against a remote path, it may takes a while since all the code is mainly composed by sequential calls to the fs. This patch will parallelize all the snapshot operations using a thread pool to dispatch requests. The size of the pool is tunable by using hbase.snapshot.thread.pool.max -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11185) Parallelize Snapshot operations
[
https://issues.apache.org/jira/browse/HBASE-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999520#comment-13999520
]
Hadoop QA commented on HBASE-11185:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644994/HBASE-11185-v0.patch
against trunk revision .
ATTACHMENT ID: 12644994
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
58 warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9517//console
This message is automatically generated.
Parallelize Snapshot operations
---
Key: HBASE-11185
URL: https://issues.apache.org/jira/browse/HBASE-11185
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.99.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE-11185-v0.patch
when SnapshotInfo or snapshot verification is executed against a remote path,
it may takes a while since all the code is mainly composed by sequential
calls to the fs.
This patch will parallelize all the snapshot operations using a thread pool
to dispatch requests. The size of the pool is tunable by using
hbase.snapshot.thread.pool.max
--
This message was sent by Atlassian JIRA
(v6.2#6252)
