[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145869#comment-16145869 ] Devaraj Das commented on HBASE-11261: - What Enis said is right. We simplified the approach and let the master do the split/merge of replicas (which essentially means closing old replicas and creating new replicas) after the split/merge of the parent is complete. > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0, 1.1.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-committed.txt, 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145826#comment-16145826 ] Enis Soztutar commented on HBASE-11261: --- The initial plan was to have the daughters refer to the parent replica until their own split is complete, so that during the split, read availability is not affected since the readers can go to the replica regions to read while the region is still splitting. However, as per above, that seemed too-complex to keep references around, especially fixing these kind of edge-cases would be pretty hard for HBCK, so I think we have simplified the approach. When a split happens, meta is updated with entries about split daughter replicas, but as far as I remember, there was not reason to do further changes in CJ for this. > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0, 1.1.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-committed.txt, 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144832#comment-16144832 ] ramkrishna.s.vasudevan commented on HBASE-11261: [~enis], [~devaraj] I can see that in case of splits you add some new qualifiers indicating that the new daughers have replicas and the same is marked with a new column in the META. The first comment here and the first patch for branch-1.2 has some logic in CatalogJanitor to trace out this new column and use that as an indicator to show that there are still references to the parent replica. And once the daughter replicas are opened those new columns are deleted. But in the merged patch and the master code that I am checking there is no such logic in CatalogJanitor. So how is that part handled where we keep the parent region from being deleted? > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0, 1.1.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-committed.txt, 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280816#comment-14280816 ] Hudson commented on HBASE-11261: FAILURE: Integrated in HBase-1.1 #87 (See [https://builds.apache.org/job/HBase-1.1/87/]) HBASE-11261. Handle splitting/merging of regions that have region_replication greater than one (ddas: rev 60e7e6aed5b624828e52ca21e9ee64f99c1e0fa1) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0, 1.1.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-committed.txt, 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065290#comment-14065290 ] Hudson commented on HBASE-11261: SUCCESS: Integrated in HBase-TRUNK #5317 (See [https://builds.apache.org/job/HBase-TRUNK/5317/]) HBASE-11261 Handle splitting/merging of regions that have region_replication greater than one (ddas: rev 72ddb74700b5abdd8474130f9061b43d0ea68bd6) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java HBASE-11261 Addendum to remove an unneeded debug message (ddas: rev 9f96d91b2e872bf8a362e2e84daa687e4050faed) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-committed.txt, 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064152#comment-14064152 ] Enis Soztutar commented on HBASE-11261: --- For these hbase-10070 Phase 2 issues, lets get them committed to master only so that we do not depend on the timeline for remaining items in hbase-10070 for releasing 1.0. If we want we can merge these set of patches to 1.0 or 1.x later. > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064154#comment-14064154 ] Enis Soztutar commented on HBASE-11261: --- Forwarding my +1 from RB. > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 2.0.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[
https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064136#comment-14064136
]
Hadoop QA commented on HBASE-11261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656134/11261-with-merge-3.txt
against trunk revision .
ATTACHMENT ID: 12656134
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestCacheConfig
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10096//console
This message is automatically generated.
> Handle splitting/merging of regions that have region_replication greater than
> one
> -
>
> Key: HBASE-11261
> URL: https://issues.apache.org/jira/browse/HBASE-11261
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Fix For: 0.99.0
>
> Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt,
> 11261-with-merge-2.txt, 11261-with-merge-3.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[ https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064118#comment-14064118 ] Enis Soztutar commented on HBASE-11261: --- bq. Removed the setup of daughter replicas temporarily referencing the parent replicas. After some thought, it seemed like that would not work with hbck and such without special handling. We can revisit this part if availability of replicas becomes a concern during a split. Agreed, let's have some experience with the region splits and replicas first. > Handle splitting/merging of regions that have region_replication greater than > one > - > > Key: HBASE-11261 > URL: https://issues.apache.org/jira/browse/HBASE-11261 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Devaraj Das > Fix For: 0.99.0 > > Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt, > 11261-with-merge-2.txt, 11261-with-merge-3.txt > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11261) Handle splitting/merging of regions that have region_replication greater than one
[
https://issues.apache.org/jira/browse/HBASE-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062947#comment-14062947
]
Hadoop QA commented on HBASE-11261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655918/11261-with-merge-2.txt
against trunk revision .
ATTACHMENT ID: 12655918
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+doReturn(new Triple,
Pair, Set>>(
+doReturn(new Triple,
Pair, Set>>(
+public void preDelete(final ObserverContext
e, final Delete delete,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.client.TestReplicaWithCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10074//console
This message is automatically generated.
> Handle splitting/merging of regions that have region_replication greater than
> one
> -
>
> Key: HBASE-11261
> URL: https://issues.apache.org/jira/browse/HBASE-11261
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Devaraj Das
> Fix For: 0.99.0
>
> Attachments: 11261-1.1.txt, 11261-1.2.txt, 11261-2.txt, 11261-3.txt,
> 11261-with-merge-2.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
