[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082770#comment-14082770 ] Hudson commented on HBASE-11516: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #406 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/406/]) HBASE-11516 Track time spent in executing coprocessors in each region (Srikanth Srungarapu and Andrew Purtell) (apurtell: rev 1d566369bb2cee7e8429b3e20450770897745503) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java * hbase-hadoop-compat/pom.xml * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082794#comment-14082794 ] Hudson commented on HBASE-11516: SUCCESS: Integrated in HBase-0.98 #429 (See [https://builds.apache.org/job/HBase-0.98/429/]) HBASE-11516 Track time spent in executing coprocessors in each region (Srikanth Srungarapu and Andrew Purtell) (apurtell: rev 1d566369bb2cee7e8429b3e20450770897745503) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java * hbase-hadoop-compat/pom.xml * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082809#comment-14082809 ] Hudson commented on HBASE-11516: FAILURE: Integrated in HBase-TRUNK #5361 (See [https://builds.apache.org/job/HBase-TRUNK/5361/]) HBASE-11516 Track time spent in executing coprocessors in each region (Srikanth Srungarapu and Andrew Purtell) (apurtell: rev 19e9b8aa5206a7954d0c02455bf39cfe45fdf6f1) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-hadoop-compat/pom.xml * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082848#comment-14082848 ] Hudson commented on HBASE-11516: FAILURE: Integrated in HBase-1.0 #80 (See [https://builds.apache.org/job/HBase-1.0/80/]) HBASE-11516 Track time spent in executing coprocessors in each region (Srikanth Srungarapu and Andrew Purtell) (apurtell: rev a1e6fc41cf6c18db34d214a58f6f40e880d8c8f1) * hbase-hadoop-compat/pom.xml * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083184#comment-14083184 ] Srikanth Srungarapu commented on HBASE-11516: - [~andrew.purt...@gmail.com] Sorry for the confusion over microseconds being represented as msec. Thanks for putting up the addendum patch and pushing this. [~tedyu] +1 on the addendum and thanks for putting it up. Unfortunately, this change which is in HBASE-11516_v5.patch got dropped in HBASE-11516_v4_master.patch Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: 11516-0.98.addendum, HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083185#comment-14083185 ] Andrew Purtell commented on HBASE-11516: +1 on addendum Oh hadoop1... Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: 11516-0.98.addendum, HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083272#comment-14083272 ] Hudson commented on HBASE-11516: SUCCESS: Integrated in HBase-0.98 #432 (See [https://builds.apache.org/job/HBase-0.98/432/]) HBASE-11516 Track time spent in executing coprocessors in each region - addendum for hadoop-1 (tedyu: rev e02698c52dcfc7f9a2a7c41b9294a138c31ebc5c) * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: 11516-0.98.addendum, HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083321#comment-14083321 ] Hudson commented on HBASE-11516: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #408 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/408/]) HBASE-11516 Track time spent in executing coprocessors in each region - addendum for hadoop-1 (tedyu: rev e02698c52dcfc7f9a2a7c41b9294a138c31ebc5c) * hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: 11516-0.98.addendum, HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, HBASE-11516_v5.patch, region_server_webui.png, rs_web_ui_v2.png, rs_web_ui_v5.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081527#comment-14081527 ] Andrew Purtell commented on HBASE-11516: I'm finding it a bit confusing the UI changes use 'msec' to mean microseconds (e.g. should that be usec). What about showing these metrics as milliseconds out to three decimal places [~srikanth235] and using a unit label of ms? Let me put up a patch. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, region_server_webui.png, rs_web_ui_v2.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080347#comment-14080347 ] Andrew Purtell commented on HBASE-11516: +1 v4 patch looks good. There is a minor spelling error Stastics that would surface in metrics reports but I will fix that on commit. Or please feel free to upload a v5 patch with the fix. Ping [~enis] for branch-1. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, region_server_webui.png, rs_web_ui_v2.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080353#comment-14080353 ] Srikanth Srungarapu commented on HBASE-11516: - [~andrew.purt...@gmail.com] It would be great if you can fix it while committing :). Thanks so much for taking keen interest in this jira. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, region_server_webui.png, rs_web_ui_v2.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080354#comment-14080354 ] Andrew Purtell commented on HBASE-11516: Thank you very much for the patch and for being receptive to feedback [~srikanth235] Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, region_server_webui.png, rs_web_ui_v2.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080483#comment-14080483 ] Andrew Purtell commented on HBASE-11516: Going to commit tomorrow unless objection Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.99.0, 0.98.5, 2.0.0 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch, HBASE-11516_v3.patch, HBASE-11516_v4.patch, HBASE-11516_v4_master.patch, region_server_webui.png, rs_web_ui_v2.png Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[
https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073614#comment-14073614
]
Andrew Purtell commented on HBASE-11516:
v3 patch looks pretty good. UI updates look great.
{code}
@@ -2357,4 +2523,19 @@ public class RegionCoprocessorHost
}
return tracker;
}
+
+ public MapString, Long getCoprocessorExecutionTimes() {
+MapString, Long results = new HashMapString, Long();
+for (RegionEnvironment env : coprocessors) {
+ if (env.getInstance() instanceof RegionObserver) {
+long total = 0;
+for (Long time : env.getExecutionLatenciesNanos()) {
+ total += time;
+}
+total /= 1000;
+results.put(env.getInstance().getClass().getSimpleName(), total);
+ }
+}
+return results;
+ }
{code}
This only sums the sampled execution times. I think this will be misleading
because the measure won't be the real total time executing in the coprocessor
over the reporting period if we ran out of space in the sample queue. We can
report useful statistics using the samples though. Consider
DescriptiveStatistics from commons-math, we are using it elsewhere. It's not
threadsafe so shouldn't be used in place of the sample buffer, but can be used
in getCoprocessorExecutionTimes when iterating through the samples. With
DescriptiveStatistics we can get min, max, avg, various percentiles, e.g. 95th,
99th.
It might make more sense to rename getCoprocessorExecutionTimes to
getCoprocessorExecutionStatistics or similar.
Track time spent in executing coprocessors in each region.
--
Key: HBASE-11516
URL: https://issues.apache.org/jira/browse/HBASE-11516
Project: HBase
Issue Type: Improvement
Components: Coprocessors
Affects Versions: 0.98.4
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 0.98.5
Attachments: HBASE-11516.patch, HBASE-11516_v2.patch,
HBASE-11516_v3.patch, region_server_webui.png
Currently, the time spent in executing coprocessors is not yet being tracked.
This feature can be handy for debugging coprocessors in case of any trouble.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070413#comment-14070413 ] Andrew Purtell commented on HBASE-11516: Hi [~srikanth235], how is it going? Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070594#comment-14070594 ] Srikanth Srungarapu commented on HBASE-11516: - [~andrew.purt...@gmail.com] Apologies for being late as got knocked down by other tasks. Will upload a new patch no later by this weekend. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070622#comment-14070622 ] Andrew Purtell commented on HBASE-11516: Thanks for that. The reason I ask is this is something I'm very interested seeing happen so am happy to help any way I can. Thanks again! Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065348#comment-14065348 ] Srikanth Srungarapu commented on HBASE-11516: - [~andrew.purt...@gmail.com] I will definitely try incorporating all the suggestions made. But if things are not working out at my end, I would go ahead and reassign this back to you. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063949#comment-14063949 ] Andrew Purtell commented on HBASE-11516: Why not track coprocessor upcall latency the same way we track HFile read and write op latencies? Start with HFile.java, look for the 'LATENCY_BUFFER_SIZE' constant, surrounding members and methods, and related code. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064418#comment-14064418 ] Andrew Purtell commented on HBASE-11516: Thinking about this more, we could easily do orders of magnitude more coprocessor upcalls than HFile reads and writes and so using single aromic variables for counting will have a big perf impact. Should consider something like Click's high scale counters. Boundary has a maintained bug fixed version possibly worth moving to. If you'd like to try this while keeping all of the above in mind, great. If not, that's fine also, please reassign to me and I'll take it up. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch, HBASE-11516_v2.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[
https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062364#comment-14062364
]
Andrew Purtell commented on HBASE-11516:
I like the idea but not the proposed changes.
Suggestions
1) Expose this as a metric instead of changes to ClusterStatus.
or
2) When changing ClusterStatus make it easy to add more metrics like this over
time, something like:
{noformat}
repeated Metric metrics = 16;
message Metric {
required string name = 1;
required uint64 value = 2;
}
{noformat}
I'd prefer option 1. I don't think we should be passing metrics through
ClusterStatus. However, if consensus opinion is we can and should do that here,
then I prefer option 2 over the current patch.
Track time spent in executing coprocessors in each region.
--
Key: HBASE-11516
URL: https://issues.apache.org/jira/browse/HBASE-11516
Project: HBase
Issue Type: Improvement
Components: Coprocessors
Affects Versions: 0.98.4
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 0.98.5
Attachments: HBASE-11516.patch
Currently, the time spent in executing coprocessors is not yet being tracked.
This feature can be handy for debugging coprocessors in case of any trouble.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062395#comment-14062395 ] stack commented on HBASE-11516: --- Agree w/ Andy on not using ClusterStatus. We are making the info twice, once to emit via metrics and then again to put on the ClusterStatus message. ClusterStatus should die and master should consume metrics. Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062422#comment-14062422 ] Andrew Purtell commented on HBASE-11516: bq. ClusterStatus should die and master should consume metrics. That's great, used it to file HBASE-11519 Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[
https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061669#comment-14061669
]
Hadoop QA commented on HBASE-11516:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655685/HBASE-11516.patch
against trunk revision .
ATTACHMENT ID: 12655685
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10066//console
This message is automatically generated.
Track time spent in executing coprocessors in each region.
--
Key: HBASE-11516
URL: https://issues.apache.org/jira/browse/HBASE-11516
Project: HBase
Issue Type: Improvement
Components: Coprocessors
Affects Versions: 0.98.4
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 0.98.5
Attachments: HBASE-11516.patch
Currently, the time spent in executing coprocessors is not yet being tracked.
This feature can be handy for debugging coprocessors in case of any trouble.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11516) Track time spent in executing coprocessors in each region.
[ https://issues.apache.org/jira/browse/HBASE-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061705#comment-14061705 ] Anoop Sam John commented on HBASE-11516: Not checked the patch. +1 for the idea. Good on you. I will see the patch some time later today. Seems QA can't apply the patch Track time spent in executing coprocessors in each region. -- Key: HBASE-11516 URL: https://issues.apache.org/jira/browse/HBASE-11516 Project: HBase Issue Type: Improvement Components: Coprocessors Affects Versions: 0.98.4 Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Fix For: 0.98.5 Attachments: HBASE-11516.patch Currently, the time spent in executing coprocessors is not yet being tracked. This feature can be handy for debugging coprocessors in case of any trouble. -- This message was sent by Atlassian JIRA (v6.2#6252)
