[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122499#comment-14122499 ] Hudson commented on HBASE-11877: SUCCESS: Integrated in HBase-0.98 #497 (See [https://builds.apache.org/job/HBase-0.98/497/]) HBASE-11877 Make TableSplit more readable (Liu Shaohui) (stack: rev 817f30110e6fdcba468c848f4dc458ecf164ce1e) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestSplitTable.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Fix For: 0.99.0, 2.0.0, 0.98.7 Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122557#comment-14122557 ] Hudson commented on HBASE-11877: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #471 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/471/]) HBASE-11877 Make TableSplit more readable (Liu Shaohui) (stack: rev 817f30110e6fdcba468c848f4dc458ecf164ce1e) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSplit.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestSplitTable.java Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Fix For: 0.99.0, 2.0.0, 0.98.7 Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122593#comment-14122593 ] Hudson commented on HBASE-11877: SUCCESS: Integrated in HBase-1.0 #153 (See [https://builds.apache.org/job/HBase-1.0/153/]) HBASE-11877 Make TableSplit more readable (Liu Shaohui) (stack: rev c0d81e9ad014609c7a5e118e66b902f828818edd) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestSplitTable.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSplit.java Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Fix For: 0.99.0, 2.0.0, 0.98.7 Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122610#comment-14122610 ] Hudson commented on HBASE-11877: FAILURE: Integrated in HBase-TRUNK #5468 (See [https://builds.apache.org/job/HBase-TRUNK/5468/]) HBASE-11877 Make TableSplit more readable (Liu Shaohui) (stack: rev aa05ad1291130919383455d39a7b3679c7b636d6) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSplit.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestSplitTable.java Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Fix For: 0.99.0, 2.0.0, 0.98.7 Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122832#comment-14122832 ] Jean-Marc Spaggiari commented on HBASE-11877: - Sorry, I prepared a comment yesterday but forgot to press Add :( Here it is, even if to lte. I checked the Bytes. code, etc. Looks good to me. Thanks fo the details and for the patch +1 Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Fix For: 0.99.0, 2.0.0, 0.98.7 Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121287#comment-14121287 ] Liu Shaohui commented on HBASE-11877: - [~jmspaggi] [~stack] What's your suggestions about the new patch? Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119435#comment-14119435 ] Liu Shaohui commented on HBASE-11877: - [~jmspaggi] [~stack] {quote} Don't see any issue with that. Have you ran it locally? Do you have a copy of the output? {quote} The split output from TestCopyTable {code} 2014-09-03 13:42:55,180 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: HBase table split(table name: testStartStopRow1, start row: row1, end row: row2, region location: localhost) {code} {quote} Has it passed the tests? {quote} Yes, all tests passed in my dev machine {quote} Not anyrisk for those new fields (m_tableName, m_regionLocation) to be null? {quote} The append method of StringBuilder and Bytes.toStringBinary have handled the null object situation. If the object is null, the method will transform it to string null. Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119669#comment-14119669 ] Hadoop QA commented on HBASE-11877: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666163/HBASE-11877-trunk-v2.diff against trunk revision . ATTACHMENT ID: 12666163 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10692//console This message is automatically generated. Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff, HBASE-11877-trunk-v2.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118184#comment-14118184 ] Jean-Marc Spaggiari commented on HBASE-11877: - Don't see any issue with that. Have you ran it locally? Do you have a copy of the output? Has it passed the tests? Not anyrisk for those new fields (m_tableName, m_regionLocation) to be null? I don't think so, but just asking. Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118252#comment-14118252 ] Hadoop QA commented on HBASE-11877: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665900/HBASE-11877-trunk-v1.diff against trunk revision . ATTACHMENT ID: 12665900 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationSmallTests org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManager {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers.testEncodedSeeker(TestEncodedSeekers.java:120) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10669//console This message is automatically generated. Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11877) Make TableSplit more readable
[ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118545#comment-14118545 ] stack commented on HBASE-11877: --- +1 on patch (the test failure is not related?) Waiting on answer to JMS questions before committing. Make TableSplit more readable - Key: HBASE-11877 URL: https://issues.apache.org/jira/browse/HBASE-11877 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Minor Attachments: HBASE-11877-trunk-v1.diff When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from. But the table split object is hard to read. eg: {code} 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0 {code} See: TableSplit.java {code} @Override public String toString() { return m_regionLocation + : + Bytes.toStringBinary(m_startRow) + , + Bytes.toStringBinary(m_endRow); } {code} We should make it more readable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)