[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140921#comment-14140921 ] Lars Hofhansl commented on HBASE-11957: --- [~apurtell], [~stack], any opinions? Looks good to me. Would need to be sure that we maintain binary compatibility for coprocessors. Backport HBASE-5974 to 0.94 --- Key: HBASE-11957 URL: https://issues.apache.org/jira/browse/HBASE-11957 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Critical Fix For: 0.94.24 Attachments: HBASE-5974-0.94-v1.diff, verify-test.patch HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect, which cause data missing in hbase scan. I think we should fix it in 0.94. [~lhofhansl] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140941#comment-14140941 ] stack commented on HBASE-11957: --- My opinion is its an important fix. How you think it could break CP API? I don't see it. Backport HBASE-5974 to 0.94 --- Key: HBASE-11957 URL: https://issues.apache.org/jira/browse/HBASE-11957 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Critical Fix For: 0.94.24 Attachments: HBASE-5974-0.94-v1.diff, verify-test.patch HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect, which cause data missing in hbase scan. I think we should fix it in 0.94. [~lhofhansl] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[
https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140964#comment-14140964
]
Lars Hofhansl commented on HBASE-11957:
---
Thought maybe this:
{code}
+ final MapString, RegionScannerHolder scanners =
+new ConcurrentHashMapString, RegionScannerHolder();
{code}
But it's not public and a reference to it does not leak into the APIs.
Allright then. Going to commit. Thanks [~liushaohui].
Backport HBASE-5974 to 0.94
---
Key: HBASE-11957
URL: https://issues.apache.org/jira/browse/HBASE-11957
Project: HBase
Issue Type: Bug
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Critical
Fix For: 0.94.24
Attachments: HBASE-5974-0.94-v1.diff, verify-test.patch
HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect,
which cause data missing in hbase scan.
I think we should fix it in 0.94.
[~lhofhansl]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133140#comment-14133140 ] Anoop Sam John commented on HBASE-11957: Patch looks good. Backport HBASE-5974 to 0.94 --- Key: HBASE-11957 URL: https://issues.apache.org/jira/browse/HBASE-11957 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Critical Fix For: 0.94.24 Attachments: HBASE-5974-0.94-v1.diff, verify-test.patch HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect, which cause data missing in hbase scan. I think we should fix it in 0.94. [~lhofhansl] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132585#comment-14132585 ] Lars Hofhansl commented on HBASE-11957: --- [~liushaohui] Are you running into this? This fix itself is fine, but we've lived with this until now. As this is changing scanning behavior I'd like to be careful. On the other hand, this is in 0.98 and hence has seen some testing. Backport HBASE-5974 to 0.94 --- Key: HBASE-11957 URL: https://issues.apache.org/jira/browse/HBASE-11957 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Critical Fix For: 0.94.24 Attachments: HBASE-5974-0.94-v1.diff HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect, which cause data missing in hbase scan. I think we should fix it in 0.94. [~lhofhansl] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[
https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132626#comment-14132626
]
Liu Shaohui commented on HBASE-11957:
-
[~lhofhansl]
{quote}
Are you running into this?
{quote}
Yes, we encountered data loss in hbase scan because of client retry.
I wrote a test to produce this problem.
{quote}
As this is changing scanning behavior I'd like to be careful.
{quote}
I think this doesn't change the scan behavior.
It just make sure data will not be lost in scan if there are client tries in
client.
Backport HBASE-5974 to 0.94
---
Key: HBASE-11957
URL: https://issues.apache.org/jira/browse/HBASE-11957
Project: HBase
Issue Type: Bug
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Critical
Fix For: 0.94.24
Attachments: HBASE-5974-0.94-v1.diff
HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect,
which cause data missing in hbase scan.
I think we should fix it in 0.94.
[~lhofhansl]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131432#comment-14131432 ] Anoop Sam John commented on HBASE-11957: Haven't gone through the back porting patch. One quick question. Do we make sure client to server compatibility? ie. older version client can talk with new server(0.94.24 with this fix) and new client to old server Backport HBASE-5974 to 0.94 --- Key: HBASE-11957 URL: https://issues.apache.org/jira/browse/HBASE-11957 Project: HBase Issue Type: Bug Reporter: Liu Shaohui Assignee: Liu Shaohui Priority: Critical Fix For: 0.94.24 Attachments: HBASE-5974-0.94-v1.diff HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect, which cause data missing in hbase scan. I think we should fix it in 0.94. [~lhofhansl] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11957) Backport HBASE-5974 to 0.94
[
https://issues.apache.org/jira/browse/HBASE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131447#comment-14131447
]
Liu Shaohui commented on HBASE-11957:
-
[~anoop.hbase]
{code}
Haven't gone through the back porting patch. One quick question. Do we make
sure client to server compatibility? ie. older version client can talk with new
server(0.94.24 with this fix) and new client to old server
{code}
Yes. Older version client can talk with new server with old next api.
New client try to use the new next api first. If there is no such methond, it
will switch to use old api.
See the code in ScannerCallable#call
Backport HBASE-5974 to 0.94
---
Key: HBASE-11957
URL: https://issues.apache.org/jira/browse/HBASE-11957
Project: HBase
Issue Type: Bug
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Critical
Fix For: 0.94.24
Attachments: HBASE-5974-0.94-v1.diff
HBASE-5974:Scanner retry behavior with RPC timeout on next() seems incorrect,
which cause data missing in hbase scan.
I think we should fix it in 0.94.
[~lhofhansl]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
