[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154563#comment-14154563 ] Anoop Sam John commented on HBASE-12112: TestAsyncProcess passing locally 1 javadoc warn is related to this patch which I will commit on fix. The findbugs warns seems not related Will commit to 0.99+ Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch, HBASE-12112_V4.patch, HBASE-12112_V4.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154593#comment-14154593 ] Hudson commented on HBASE-12112: FAILURE: Integrated in HBase-1.0 #253 (See [https://builds.apache.org/job/HBase-1.0/253/]) HBASE-12112 Avoid KeyValueUtil#ensureKeyValue some more simple cases. (anoopsamjohn: rev ebe74abda9358c9a5dad2ef8c1b800e7dc4aaf26) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellKey.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch, HBASE-12112_V4.patch, HBASE-12112_V4.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154638#comment-14154638 ] Hudson commented on HBASE-12112: FAILURE: Integrated in HBase-TRUNK #5598 (See [https://builds.apache.org/job/HBase-TRUNK/5598/]) HBASE-12112 Avoid KeyValueUtil#ensureKeyValue some more simple cases. (anoopsamjohn: rev 4fac4c1ba6fa1a0b30a798d3d1f2a8f803a5c531) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellKey.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch, HBASE-12112_V4.patch, HBASE-12112_V4.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152908#comment-14152908 ] Anoop Sam John commented on HBASE-12112: KeyOnlyFilter exposes lenAsVal as a param. So I fear we can not remove. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152920#comment-14152920 ] stack commented on HBASE-12112: --- Make it a noop? That filters use of the flag is odd. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152962#comment-14152962 ] Anoop Sam John commented on HBASE-12112: HBASE-3211 added this Filter. Any specific reason to add this boolean param? bq.Make it a noop? That filters use of the flag is odd. Any way that can be a different issue I think. There we have to deprecate the constructor taking the boolean( deprecate in 1.0 and remove in 2.0?). Also along with that I can do optimization. Now we can have Cells in read path and no need to recreate a KV and copy key part for returning from this filter transform(). If the boolean can be removed that still easier. I can have a new Cell impl (CellKey itself?) and no need for bytes copy. I can do all these in a follow on issue? Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152967#comment-14152967
]
Anoop Sam John commented on HBASE-12112:
As it may change and possibly boolean param not needed in 2.0, I will remove
below from CellUtil
public static Cell createKeyOnlyCell(Cell c, boolean lenAsVal) {
Will handle the creation in Filter class itself as of now.
Also the method and what it is doing is not always matching. CellUtil being
public exposed API, let us not mess it up.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153242#comment-14153242 ] stack commented on HBASE-12112: --- +1 Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch, HBASE-12112_V4.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154257#comment-14154257
]
Hadoop QA commented on HBASE-12112:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672233/HBASE-12112_V4.patch
against trunk revision .
ATTACHMENT ID: 12672233
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAsyncProcess
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11156//console
This message is automatically generated.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch, HBASE-12112_V4.patch, HBASE-12112_V4.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151462#comment-14151462
]
Hadoop QA commented on HBASE-12112:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671747/HBASE-12112_V2.patch
against trunk revision .
ATTACHMENT ID: 12671747
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRollingRestart
org.apache.hadoop.hbase.client.TestMultiParallel
{color:red}-1 core zombie tests{color}. There are 3 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:100)
at
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed.testTimeRangeMapRed(TestTimeRangeMapRed.java:156)
at
org.apache.camel.test.blueprint.CamelBlueprintHelper.getOsgiService(CamelBlueprintHelper.java:227)
at
org.apache.camel.test.blueprint.CamelBlueprintHelper.getOsgiService(CamelBlueprintHelper.java:202)
at
org.apache.camel.test.blueprint.CamelBlueprintTestSupport.createCamelContext(CamelBlueprintTestSupport.java:352)
at
org.apache.camel.test.junit4.CamelTestSupport.doSetUp(CamelTestSupport.java:247)
at
org.apache.camel.test.junit4.CamelTestSupport.setUp(CamelTestSupport.java:217)
at
org.apache.camel.test.blueprint.CamelBlueprintTestSupport.setUp(CamelBlueprintTestSupport.java:183)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8//console
This message is automatically generated.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch
This include fixes with
- Replace
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151464#comment-14151464
]
Hadoop QA commented on HBASE-12112:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671752/HBASE-12112_V2.patch
against trunk revision .
ATTACHMENT ID: 12671752
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.camel.test.blueprint.CamelBlueprintHelper.getOsgiService(CamelBlueprintHelper.java:227)
at
org.apache.camel.test.blueprint.CamelBlueprintHelper.getOsgiService(CamelBlueprintHelper.java:202)
at
org.apache.camel.test.blueprint.CamelBlueprintTestSupport.createCamelContext(CamelBlueprintTestSupport.java:352)
at
org.apache.camel.test.junit4.CamelTestSupport.doSetUp(CamelTestSupport.java:247)
at
org.apache.camel.test.junit4.CamelTestSupport.setUp(CamelTestSupport.java:217)
at
org.apache.camel.test.blueprint.CamelBlueprintTestSupport.setUp(CamelBlueprintTestSupport.java:183)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9//console
This message is automatically generated.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151859#comment-14151859
]
stack commented on HBASE-12112:
---
CellKey would replace places where we make a Cell with a null value. I think
that makes sense.
Add a class comment on CellKey on commit on what it is for.
Change this on commit to be getCellKey:
public static CellKey getKey(Cell cell){
Still need this even though you just added CellKey?
public static Cell createKeyOnlyCell(Cell c, boolean lenAsVal) {
In hfile v2 and v3 where you convert cell to be a cellkey just so you can
toString it, its 'clean' but expensive. I suppose it is fine. Ignore this
remark.
+1 on commit. Nice.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152760#comment-14152760
]
Anoop Sam John commented on HBASE-12112:
bq.Add a class comment on CellKey on commit on what it is for.
Sure. This holds the key portion of the Cell. And this is not a Cell as such.
bq.Change this on commit to be getCellKey:
Sure. I missed it.
{quote}
Still need this even though you just added CellKey?
public static Cell createKeyOnlyCell(Cell c, boolean lenAsVal) {
{quote}
The name really not going correct! Because if lenAsVal is true, we add a value
(which is the value length in actual cell). We need a better name. Any
suggestions?
bq.In hfile v2 and v3 where you convert cell to be a cellkey just so you can
toString it, its 'clean' but expensive. I suppose it is fine. Ignore this
remark.
Ya should be fine IMO. This is used only for an error message. The chance for
error is really rare.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch, HBASE-12112_V2.patch,
HBASE-12112_V2.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152818#comment-14152818 ] stack commented on HBASE-12112: --- bq. The name really not going correct! Because if lenAsVal is true, we add a value (which is the value length in actual cell). We need a better name. Any suggestions? Remove lenAsVal completely? It is not very useful. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch, HBASE-12112_V2.patch, HBASE-12112_V2.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151334#comment-14151334
]
Anoop Sam John commented on HBASE-12112:
{quote}
Can we avoid creating iterator here?
for (Cell cell : rs.rawCells()) {
{quote}
rawCells() return and array of Cells. So no worry.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151337#comment-14151337 ] Anoop Sam John commented on HBASE-12112: bq. Shall we call it getKey? Should we make a new object Key that has the Key stuff from Cell in it? I like this idea. A key object which is having all rk, cf, q, ts and typo info. A getKey(Cell) in CellUtil would be good. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151339#comment-14151339 ] stack commented on HBASE-12112: --- ok on the toJSON. Expensive -- espcially when it is subsequently json'ized -- but makes sense. Ok on the rawcells. Maybe comment that no iterator is made in this case. Otherwise all good by me. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[ https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150641#comment-14150641 ] Anoop Sam John commented on HBASE-12112: bq.In CellComparator is there something that does the below? If not, should we add it? Yes. Thanks.. I can use it. That will be better. bq.ClonedSeekerState is serializing same way KV did? that is why the heapsize calc works? The fixed over head is different from KV. The dynamic part is the lengths of individual components bq. Are we perpetuating the old KV serialization surrepticiously here? It is just used in some Exception messages and toString impls. I think better we can change these places to have some thing like rk :rk cf: f q: q ts type message. No need to create the key as it would look like in KV. I was just trying to be like the old way. I can chage. Sounds good? bq.This thing is kinda crazy cellToStringMap (Its not you, you are just replacing what was there). Is that necessary? Again was trying to be like the old way. This is used by toJSON() and you can see Scan/Get etc also implements it with adding their details. I think we can continue to have this. Avoid KeyValueUtil#ensureKeyValue some more simple cases Key: HBASE-12112 URL: https://issues.apache.org/jira/browse/HBASE-12112 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12112.patch This include fixes with - Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell) - Printing the key portion of a cell (rk+cf+q+ts+type). These are in Exception messages - HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to cell#getxxx() which involves bytes copying. This is not a hot area still we can avoid as much usage of deprecated methods as possible in core code. I believe these bytes copying methods are used in many other parts and later we can try fixing those as per area importance - Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150374#comment-14150374
]
Hadoop QA commented on HBASE-12112:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671616/HBASE-12112.patch
against trunk revision .
ATTACHMENT ID: 12671616
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:339)
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:100)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11108//console
This message is automatically generated.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12112) Avoid KeyValueUtil#ensureKeyValue some more simple cases
[
https://issues.apache.org/jira/browse/HBASE-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150391#comment-14150391
]
stack commented on HBASE-12112:
---
Can we avoid creating iterator here?
for (Cell cell : rs.rawCells()) {
This thing is kinda crazy cellToStringMap (Its not you, you are just replacing
what was there). Is that necessary?
I don't get getFlatKey even now. It is just the key part serialized as kv?
Should it be in CellUtil? Can we give it better name? Should we even be doing
this getFlatKey serialization? Are we perpetuating the old KV serialization
surrepticiously here? Shall we call it getKey? Should we make a new object
Key that has the Key stuff from Cell in it?
ClonedSeekerState is serializing same way KV did? that is why the heapsize
calc works?
In CellComparator is there something that does the below? If not, should we
add it?
int result = Bytes.compareTo(cell.getRowArray(),
cell.getRowOffset(), cell.getRowLength(),
316 row, 0, row.length);
CellComparator I'm pretty sure has means of comparing two Cells.
if (Bytes.compareTo(pCell.getRowArray(), pCell.getRowOffset(),
pCell.getRowLength(),
347 cell.getRowArray(), cell.getRowOffset(),
cell.getRowLength()) 0) {
Very nice cleanup.
Avoid KeyValueUtil#ensureKeyValue some more simple cases
Key: HBASE-12112
URL: https://issues.apache.org/jira/browse/HBASE-12112
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12112.patch
This include fixes with
- Replace KeyValue#heapSize() with CellUtil#estimatedHeapSizeOf(Cell)
- Printing the key portion of a cell (rk+cf+q+ts+type). These are in
Exception messages
- HFilePrettyPrinter - Avoiding ensureKeyValue() calls and calls to
cell#getxxx() which involves bytes copying. This is not a hot area still we
can avoid as much usage of deprecated methods as possible in core code. I
believe these bytes copying methods are used in many other parts and later we
can try fixing those as per area importance
- Creating CellUtil#createKeyOnlyCell and using that in KeyOnlyFilter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
