[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[
https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158516#comment-14158516
]
Hadoop QA commented on HBASE-12136:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672836/HBASE-12136-0.98.patch
against trunk revision .
ATTACHMENT ID: 12672836
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11210//console
This message is automatically generated.
Race condition between client adding tableCF replication znode and server
triggering TableCFsTracker
-
Key: HBASE-12136
URL: https://issues.apache.org/jira/browse/HBASE-12136
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.98.6
Reporter: Virag Kothari
Assignee: Virag Kothari
Fix For: 2.0.0, 0.98.7, 0.99.1
Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch
In ReplicationPeersZKImpl.addPeer(), there is a race between client creating
tableCf znode and the server triggering TableCFsTracker. If the server wins,
it wont be able to read the data set on tableCF znode and replication will
be misconfigured
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158556#comment-14158556 ] Ted Yu commented on HBASE-12136: There was a conflict in hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java which I resolved. Integrated to 0.98, branch-1 and master Thanks for the contribution, Virag Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158575#comment-14158575 ] Hudson commented on HBASE-12136: FAILURE: Integrated in HBase-1.0 #271 (See [https://builds.apache.org/job/HBase-1.0/271/]) HBASE-12136 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker (Virag Kothari) (tedyu: rev 6b95b4a8a4a49dc7877271118c36d5e916d336ab) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158590#comment-14158590 ] Virag Kothari commented on HBASE-12136: --- In https://builds.apache.org/job/HBase-1.0/271, org.apache.hadoop.hbase.util.TestTableName.testValueOf fails. That might be related to HBASE-12156 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158610#comment-14158610 ] Hudson commented on HBASE-12136: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #539 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/539/]) HBASE-12136 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker (Virag Kothari) (tedyu: rev a9138d7f96910f09e52b226248ccb169c98d6bd4) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158659#comment-14158659 ] Hudson commented on HBASE-12136: FAILURE: Integrated in HBase-TRUNK #5617 (See [https://builds.apache.org/job/HBase-TRUNK/5617/]) HBASE-12136 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker (Virag Kothari) (tedyu: rev efe0787c87ca03e548bec13d8ae24200f582b438) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158757#comment-14158757 ] Hudson commented on HBASE-12136: FAILURE: Integrated in HBase-0.98 #568 (See [https://builds.apache.org/job/HBase-0.98/568/]) HBASE-12136 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker (Virag Kothari) (tedyu: rev a9138d7f96910f09e52b226248ccb169c98d6bd4) * hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12136-0.98.patch, HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154490#comment-14154490 ] Virag Kothari commented on HBASE-12136: --- If useMulti is set to true, then the operations of adding a peer znode and its children such as peer -state and tableCf will be atomic making the server change redundant. However if the useMulti is not configured, then we need to have a nodeCreated() event on the tracker so that even on race condition, the nodeCreated() will make sure to refresh the tableCf config. The TestPerTableCFReplication.testPerTableCFReplication() should no longer be flakey. Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[
https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154607#comment-14154607
]
Hadoop QA commented on HBASE-12136:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672271/HBASE-12136.patch
against trunk revision .
ATTACHMENT ID: 12672271
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
{color:red}-1 core zombie tests{color}. There are 7 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery.testSplitWhileBulkLoadPhase(TestLoadIncrementalHFilesSplitRecovery.java:339)
at
org.apache.hadoop.hbase.replication.regionserver.TestReplicationHLogReaderManager.test(TestReplicationHLogReaderManager.java:180)
at
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:100)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11164//console
This message is automatically generated.
Race condition between client adding tableCF replication znode and server
triggering TableCFsTracker
-
Key: HBASE-12136
URL: https://issues.apache.org/jira/browse/HBASE-12136
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.98.6
Reporter: Virag Kothari
Assignee: Virag Kothari
Attachments: HBASE-12136.patch
In ReplicationPeersZKImpl.addPeer(), there is a race between client creating
tableCf znode and the server triggering TableCFsTracker. If the server wins,
it wont be able to read the data set on tableCF znode and replication will
be misconfigured
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[ https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154716#comment-14154716 ] Ted Yu commented on HBASE-12136: +1 Race condition between client adding tableCF replication znode and server triggering TableCFsTracker - Key: HBASE-12136 URL: https://issues.apache.org/jira/browse/HBASE-12136 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12136.patch In ReplicationPeersZKImpl.addPeer(), there is a race between client creating tableCf znode and the server triggering TableCFsTracker. If the server wins, it wont be able to read the data set on tableCF znode and replication will be misconfigured -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12136) Race condition between client adding tableCF replication znode and server triggering TableCFsTracker
[
https://issues.apache.org/jira/browse/HBASE-12136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155152#comment-14155152
]
Ted Yu commented on HBASE-12136:
Virag:
Can you provide patch for 0.98 ?
I got:
{code}
|---
a/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java
|+++
b/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java
--
File to patch:
{code}
Race condition between client adding tableCF replication znode and server
triggering TableCFsTracker
-
Key: HBASE-12136
URL: https://issues.apache.org/jira/browse/HBASE-12136
Project: HBase
Issue Type: Bug
Components: Replication
Affects Versions: 0.98.6
Reporter: Virag Kothari
Assignee: Virag Kothari
Fix For: 2.0.0, 0.98.7, 0.99.1
Attachments: HBASE-12136.patch
In ReplicationPeersZKImpl.addPeer(), there is a race between client creating
tableCf znode and the server triggering TableCFsTracker. If the server wins,
it wont be able to read the data set on tableCF znode and replication will
be misconfigured
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
