[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178662#comment-14178662 ] Sean Busbey commented on HBASE-12299: - As a part of this, can we correct the need of the javadoc plugin for hbase-annotations? Since the root pom specifies the javadoc dependency for all modules ATM it creates a circular need with the hbase-annotations module. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178672#comment-14178672 ] Andrew Purtell commented on HBASE-12299: bq. As a part of this, can we correct the need of the javadoc plugin for hbase-annotations? I think that should be a separate issue. We are having a problem right now staging 0.98.7 to our internal Nexus because the system scope dependency on tools.jar is disallowed by the default Nexus rule set. System scope dependencies will apparently not be supported in Maven 4. I'd like to question the need for a custom Javadoc processor entirely in a different issue. Maybe we can rip that all out. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178675#comment-14178675 ] Andrew Purtell commented on HBASE-12299: bq. -Dtest=test is still broken since the checkstyle module does not set failIfNoTests to false, and hence every run with -Dtest=... will fail. I'm going to put up a new patch set including a fix for this momentarily. Dealing with an internal issue at the moment (see above comment). Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178682#comment-14178682 ] Andrew Purtell commented on HBASE-12299: Also let me check if that's actually needed. [~lhofhansl] might have been using what's checked in not one of the patches that adds the parent. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178707#comment-14178707 ] Andrew Purtell commented on HBASE-12299: I filed HBASE-12310 for the hbase-annotations javadoc issues Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178752#comment-14178752 ] Andrew Purtell commented on HBASE-12299: We don't need any additional changes to get {{-Dtest=...}} working after the checkstyle module has been hooked up to the parent. Just checked with the patch on this issue. {noformat} $ mvn clean install -Dtest=TestAtomicOperation -DskipITs ... --- T E S T S --- Running org.apache.hadoop.hbase.regionserver.TestAtomicOperation Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.092 sec Results : Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 ... [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:29 min [INFO] Finished at: 2014-10-21T11:02:31-08:00 [INFO] Final Memory: 122M/1171M {noformat} Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176948#comment-14176948 ] Andrew Purtell commented on HBASE-12299: I notice also that when I used Maven to renumber the version in POMs, the hbase-checkstyle module was skipped. The hbase-checkstyle POM doesn't specify a parent. Let me try that. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Fix For: 2.0.0, 0.98.8, 0.99.2 {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176949#comment-14176949 ] Andrew Purtell commented on HBASE-12299: And while we are at it, perhaps we can nest hbase-checkstyle one level down?, e.g. {noformat} hbase-dev-tools/ hbase-checkstyle/ {noformat} because we might be introducing more dev tooling as Maven modules with things like HBASE-11912. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Fix For: 2.0.0, 0.98.8, 0.99.2 {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176998#comment-14176998 ] Sean Busbey commented on HBASE-12299: - I think this is a dup of HBASE-12294. Elliot has some concerns on that ticket about adding a parent. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177159#comment-14177159 ] Hadoop QA commented on HBASE-12299: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675860/HBASE-12299-master.patch against trunk revision . ATTACHMENT ID: 12675860 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 2 release audit warnings (more than the trunk's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; + xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11404//console This message is automatically generated. Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single
[jira] [Commented] (HBASE-12299) Can't assemble tarballs after HBASE-12261
[ https://issues.apache.org/jira/browse/HBASE-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177916#comment-14177916 ] Andrew Purtell commented on HBASE-12299: If I rm -rf ~/.m2/repository/org/apache/ and then do {{mvn -DskipTests clean install mvn -DskipTests site package assembly:single}} on 0.98 branch with the latest 0.98 patch on HBASE-12299 applied, everything builds successfully and the assembly target produces a tarball that will boot in-tree. What's left to do? Can't assemble tarballs after HBASE-12261 - Key: HBASE-12299 URL: https://issues.apache.org/jira/browse/HBASE-12299 Project: HBase Issue Type: Bug Reporter: Andrew Purtell Priority: Blocker Attachments: HBASE-12299-0.98.patch, HBASE-12299-branch-1.patch, HBASE-12299-master.patch, HBASE-12299.patch {{$ mvn -DskipTests clean install package assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-checkstyle:jar:0.98.7 (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. $ {{mvn -DskipTests clean install package mvn -DskipTests assembly:single}} ... ERROR Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (default-cli) on project hbase-assembly: Failed to create assembly: Artifact: org.apache.hbase:hbase-annotations:jar:0.98.8-SNAPSHOT (included by module) does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)