[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299684#comment-16299684 ] stack commented on HBASE-12341: --- Update: In a subissue we moved our logging interface over to slf4j. TODO, change our backend, a new subissue hanging off this one. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109809#comment-16109809 ] stack commented on HBASE-12341: --- Unscheduling from 2.0.0. We are not going to do log4j2. Other issues raised herein have not gotten any attention. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[
https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668829#comment-15668829
]
Enis Soztutar commented on HBASE-12341:
---
maven enforcer can enforce converging dependencies:
{code}
org.apache.maven.plugins
maven-enforcer-plugin
depcheck
true
enforce
verify
{code}
> Overhaul logging; log4j2, machine-readable, etc.
>
>
> Key: HBASE-12341
> URL: https://issues.apache.org/jira/browse/HBASE-12341
> Project: HBase
> Issue Type: Umbrella
>Reporter: stack
>Priority: Critical
> Fix For: 2.0.0
>
>
> This is a general umbrella issue for 2.x logging improvements. Hang related
> work off this one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668760#comment-15668760 ] Andrew Purtell commented on HBASE-12341: slf4j instead of commons-logging for logging facade wouldn't be the worst option. If both we and Hadoop specify differing slf4j versions I think Maven would do the right thing and only one slf4j implementation jar would be on the classpath of our binary convenience artifacts, avoiding the annoying message Stack mentions. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[
https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668709#comment-15668709
]
stack commented on HBASE-12341:
---
Sample annoying message dumped on brand new build of master:
{code}
stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase/ shell
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/home/stack/hbase-2.0.0-SNAPSHOT/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/home/stack/hadoop-2.7.3-SNAPSHOT/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
{code}
slf4j is not what we use for logging. Its 3rd-party usage. At least the
complaint is clean. We need to clean this stuff up. Looks bad.
> Overhaul logging; log4j2, machine-readable, etc.
>
>
> Key: HBASE-12341
> URL: https://issues.apache.org/jira/browse/HBASE-12341
> Project: HBase
> Issue Type: Umbrella
>Reporter: stack
>Priority: Critical
> Fix For: 2.0.0
>
>
> This is a general umbrella issue for 2.x logging improvements. Hang related
> work off this one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[
https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668415#comment-15668415
]
Enis Soztutar commented on HBASE-12341:
---
I did a 5 min google search.
Seems that we are using commons-logging 1.2 which is the latest version and it
does not have the lazy string interpolation or Java-8 lambda style.
Lazy arguments will give us usage like this:
{code}
LOG.debug("Found a problem: {} with this {}", arg1, arg2);
{code}
instead of
{code}
if (LOG.isDebugEnabled()) {
LOG.debug("Found a problem:" + arg1 + "with this" + arg2);
}
{code}
Lambda lazy evaluation would be something like this:
{code}
LOG.debug("Result of computing something costly: {}", () ->
doSomethingCostly());
{code}
I don't care too much about lambdas in logging, because there is then the
overhead of capturing the lambda, although it will lazy execute.
Then the question is whether moving to log4j2 APIs directly, or moving to slf4j
first then moving to log4j2 after. We can easily do the two steps
independently.
> Overhaul logging; log4j2, machine-readable, etc.
>
>
> Key: HBASE-12341
> URL: https://issues.apache.org/jira/browse/HBASE-12341
> Project: HBase
> Issue Type: Umbrella
>Reporter: stack
>Priority: Critical
> Fix For: 2.0.0
>
>
> This is a general umbrella issue for 2.x logging improvements. Hang related
> work off this one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667904#comment-15667904 ] Sean Busbey commented on HBASE-12341: - please start a [DISCUSS] thread on this. Unless commons-logging has been updated to allow for lazy string interpolation than it's not worth keeping, IMHO. all the extra checks for explicit logging levels suck. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666069#comment-15666069 ] stack commented on HBASE-12341: --- On commons-logging to log4j2, see the bridge: http://logging.apache.org/log4j/2.x/log4j-jcl/ I've not tried it. On SLF4J, I know little other than annoying message if two SLF4J instances on classpath and that you can't change logging level programmatically (which is a mite annoying, an issue we have in commons-logging). > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665776#comment-15665776 ] Enis Soztutar commented on HBASE-12341: --- We use commons-logging as the API. Is there bindings for log4j2? Not sure slf4j API is better than commons-logging. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664288#comment-15664288 ] stack commented on HBASE-12341: --- No discussion as yet. Need one soon. Would be survey, why our current logging API doesn't cut it, should we go slf4j as some of our dependencies do... etc. > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662821#comment-15662821 ] Nick Dimiduk commented on HBASE-12341: -- Has there been a design discussion on this topic? Anyone mention moving to a log API (ie, slf4j) and leaving the backend up to runtime decision? > Overhaul logging; log4j2, machine-readable, etc. > > > Key: HBASE-12341 > URL: https://issues.apache.org/jira/browse/HBASE-12341 > Project: HBase > Issue Type: Umbrella >Reporter: stack >Priority: Critical > Fix For: 2.0.0 > > > This is a general umbrella issue for 2.x logging improvements. Hang related > work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658502#comment-14658502 ] Andrew Purtell commented on HBASE-12341: We should consider reviving this now that log4j v1 is officially EOL: https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces Overhaul logging; log4j2, machine-readable, etc. Key: HBASE-12341 URL: https://issues.apache.org/jira/browse/HBASE-12341 Project: HBase Issue Type: Umbrella Reporter: stack Fix For: 2.0.0 This is a general umbrella issue for 2.x logging improvements. Hang related work off this one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
