[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237166#comment-14237166 ] Gaurav Menghani commented on HBASE-12510: - Ok, so I am going to rename this JIRA to indicate that this was only for HRegionInfo. We will file separate JIRAs for the remaining work. > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237045#comment-14237045 ] Elliott Clark commented on HBASE-12510: --- I would say multiple jiras would be easier that way the commits are easy to match up to the patches that were posted last on jira. > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237033#comment-14237033 ] Gaurav Menghani commented on HBASE-12510: - Awesome! Thanks Elliott! This is a somewhat bigger 'task' with multiple parts, but JIRA doesn't let me create subtask for this, since this is already a subtask of HBASE-12259. Do you suggest we file separate JIRAs, or just keep adding multiple patches here and we can commit with the same JIRA number? > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236969#comment-14236969 ] Elliott Clark commented on HBASE-12510: --- Pushed 002 version of the patch to the feature branch. Everything compiled well. Tests are currently running. > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236890#comment-14236890 ] Gaurav Menghani commented on HBASE-12510: - Sure, [~stack]! Yes, awaiting either of them to commit this patch. We would be posting patches. This JIRA might have multiple patches, since this has multiple parts. We can discuss the integration of master with QuorumInfo this once we land HBASE-12499 and HBASE-12500. > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236880#comment-14236880 ] stack commented on HBASE-12510: --- Patch looks like good progress. You don't need our +1 for commit to branch. You just need blessing of [~eclark] and [~amitanand] and for them to do the commit on the branch for you. Please do keep going via JIRA and posting patches if you don't mind because it helps us follow-along. I'd be interested in learning if any plans for unifying QuorumInfo and master branches accounting of replicas by making note in hbase:meta -- we can chat on this at some point but too early for now. > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > Attachments: > 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, > 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch > > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233628#comment-14233628 ] Gaurav Menghani commented on HBASE-12510: - First diff out on Phabricator: https://reviews.facebook.net/D29685 > Remove the dependency on 0.89-fb branch for HydraBase > - > > Key: HBASE-12510 > URL: https://issues.apache.org/jira/browse/HBASE-12510 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Rishit Shroff >Assignee: Gaurav Menghani >Priority: Minor > > The current RAFT protocol implementation depends on few classes (8) which > were present in 0.89-fb branch. The latest HBase branch may have other > equivalents of it and we need to cleanup/refactor to code to use them. > Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)