[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238452#comment-14238452 ] Hudson commented on HBASE-12611: SUCCESS: Integrated in HBase-1.0 #551 (See [https://builds.apache.org/job/HBase-1.0/551/]) HBASE-12611 Create autoCommit() method and remove clearBufferOnFail (Solomon Duskis) (stack: rev 823656bf8372e55b5b4a81e72921cb78b0be96d7) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12611.patch, HBASE-12611B.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238424#comment-14238424 ] Hudson commented on HBASE-12611: SUCCESS: Integrated in HBase-TRUNK #5887 (See [https://builds.apache.org/job/HBase-TRUNK/5887/]) HBASE-12611 Create autoCommit() method and remove clearBufferOnFail (Solomon Duskis) (stack: rev 4b1983c89dde74396cd1d41984df5f5b62a47193) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0, 2.0.0 > > Attachments: HBASE-12611.patch, HBASE-12611B.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237072#comment-14237072 ] Hadoop QA commented on HBASE-12611: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685585/HBASE-12611B.patch against master branch at commit ca0c1774c95a3ec215981359ad0e7ed0ccc6a7f4. ATTACHMENT ID: 12685585 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11979//console This message is automatically generated. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch, HBASE-12611B.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234846#comment-14234846 ] Nick Dimiduk commented on HBASE-12611: -- [~nkeywal]'s concerns re: confusion with an actual transactional system are valid. The API proposed in v5 PDF on HBASE-11447 does indeed extend the Table interface, so having autoCommit here will likely be problematic. That API doesn't include a notion of autoCommit, however. Abort the rename but go forward with removing clearBufferOnFail? Sorry for the run-around [~sduskis]. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234824#comment-14234824 ] Solomon Duskis commented on HBASE-12611: stack asked about the is vs. get issue as well. Since we used java.sql.Connection as a an example for setAutoCommit(), I used java.sql.Connection's getAutoCommit() syntax as well. If you want me to change it to isAutoCommit(), I can do that. See [~stack]'s comment above. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234055#comment-14234055 ] Nicolas Liochon commented on HBASE-12611: - bq. stack and Nick Dimiduk came to the conclusion that the flush method should be called autoCommit() similar to the SQL APIs. Sorry for beeing late in the game. The meaning in SQL is slightly different. In jdbc, whatever the value for autoCommit, the query will be sent to be server and executed. autocommit is set to false if the client application wants to send multiple queries within a single transaction (and then it will do a begin/commit explicitly). I haven't double checked if it's the standard or an implementation detail (the docs are not very clear), but it's unlikely to change anyway: there is another set of methods for batches in jdbc. Our old autoFlush is different as it impacts the client behavior. I think we're creating a confusion here. Moreover, if we add transactions between rows in the future, then may be we will want to use autoCommit for what it really is. As I'm very late here I leave the decision to you, but we should at least be clear in the javadoc imho. bq. Do we also want to change the default with this patch? I like the fact that HBase its secure by default and it would be very confusing for the users as well imho. {code} - public boolean isAutoFlush() { -return autoFlush; + public boolean getAutoCommit() { +return autoCommit; {code} If I'm not wrong we use 'is' for getters on boolean? > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233796#comment-14233796 ] Enis Soztutar commented on HBASE-12611: --- Can we deprecate the method setAutoFlush(boolean,boolean) instead of removing (and maybe others). At least for 1.0.0 we may need that to be API compatible with 0.98. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233587#comment-14233587 ] Nick Dimiduk commented on HBASE-12611: -- If java.sql.Connection calls it get/setAutoCommit, I'm good with that too. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233507#comment-14233507 ] stack commented on HBASE-12611: --- Man, we should use the javadoc from there https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#setAutoCommit(boolean) > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233503#comment-14233503 ] stack commented on HBASE-12611: --- [~sduskis] Smile. Good. Thanks. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233436#comment-14233436 ] Solomon Duskis commented on HBASE-12611: I used the SQL Connection interface as a guide. It has getAutoCommit(). I'd be glad to change getAutoCommit() to isAutoCommit(), if that's what makes more sense for HBase. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233354#comment-14233354 ] stack commented on HBASE-12611: --- Good by me. Doesn't change behavior. Change getAutoCommit to isAutoCommit? > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233249#comment-14233249 ] Hadoop QA commented on HBASE-12611: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684904/HBASE-12611.patch against master branch at commit 13a1eaec09a467153adc1ee0b46df9f457da6115. ATTACHMENT ID: 12684904 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 63 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 3539 checkstyle errors (more than the master's current 3538 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11932//console This message is automatically generated. > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12611) Create autoCommit() method and remove clearBufferOnFail
[ https://issues.apache.org/jira/browse/HBASE-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233248#comment-14233248 ] Nick Dimiduk commented on HBASE-12611: -- This is what I had in mind, +1. For some reason I thought we had autoFlush disabled by default -- we wanted the performance boost out of the box. I guess I was wrong. Do we also want to change the default with this patch? [~stack] you good with this? [~nkeywal] you had an opinion about the "setter" name in the previous ticket. Care to weigh in on this new method name? > Create autoCommit() method and remove clearBufferOnFail > --- > > Key: HBASE-12611 > URL: https://issues.apache.org/jira/browse/HBASE-12611 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 0.99.2 >Reporter: Solomon Duskis >Assignee: Solomon Duskis > Fix For: 1.0.0 > > Attachments: HBASE-12611.patch > > > There was quite a bit of good discussion on HBASE-12490 about this topic. > [~stack] and [~ndimiduk] came to the conclusion that the flush method should > be called autoCommit() similar to the SQL APIs. [~ndimiduk] also suggested > that clearBufferOnFail should be removed from HTable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)