[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263404#comment-14263404 ] Hudson commented on HBASE-12750: SUCCESS: Integrated in HBase-1.0 #627 (See [https://builds.apache.org/job/HBase-1.0/627/]) HBASE-12750 getRequestsCount() in ClusterStatus returns total number of request (Weichen Ye) (enis: rev 9403a1b640eda5f292a5bcd2594f37f986802618) * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263359#comment-14263359 ] Enis Soztutar commented on HBASE-12750: --- Pushed to 1.0.0 as well. > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257771#comment-14257771 ] Weichen Ye commented on HBASE-12750: [~te...@apache.org] Thank you for your review! I`ll continue working for HBASE-12716 and HBASE-12590. > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257612#comment-14257612 ] Hudson commented on HBASE-12750: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #724 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/724/]) HBASE-12750 getRequestsCount() in ClusterStatus returns total number of request (Weichen Ye) (tedyu: rev 6dfb2580706c9844883622e38ab19d8f8aadbe5c) * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257560#comment-14257560 ] Hudson commented on HBASE-12750: SUCCESS: Integrated in HBase-0.98 #758 (See [https://builds.apache.org/job/HBase-0.98/758/]) HBASE-12750 getRequestsCount() in ClusterStatus returns total number of request (Weichen Ye) (tedyu: rev 6dfb2580706c9844883622e38ab19d8f8aadbe5c) * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257515#comment-14257515 ] Hudson commented on HBASE-12750: SUCCESS: Integrated in HBase-1.1 #21 (See [https://builds.apache.org/job/HBase-1.1/21/]) HBASE-12750 getRequestsCount() in ClusterStatus returns total number of request (Weichen Ye) (tedyu: rev 59f93e23842d4528690adc92493d242ef48a81f3) * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257467#comment-14257467 ] Hudson commented on HBASE-12750: SUCCESS: Integrated in HBase-TRUNK #5962 (See [https://builds.apache.org/job/HBase-TRUNK/5962/]) HBASE-12750 getRequestsCount() in ClusterStatus returns total number of request (Weichen Ye) (tedyu: rev 700de7d92c11cb021f025407994080d7704b4759) * hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257458#comment-14257458 ] stack commented on HBASE-12750: --- [~te...@apache.org] I'll take your word for it that it works. Thanks. > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[
https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257433#comment-14257433
]
Ted Yu commented on HBASE-12750:
UI references getNumberOfRequests() directly:
{code}
totalRequests += sl.getNumberOfRequests();
{code}
> getRequestsCount() in ClusterStatus returns total number of request
> ---
>
> Key: HBASE-12750
> URL: https://issues.apache.org/jira/browse/HBASE-12750
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0, 0.98.6
>Reporter: Weichen Ye
>Assignee: Weichen Ye
> Fix For: 2.0.0, 0.98.10, 1.1.0
>
> Attachments: HBASE-12750.patch
>
>
> getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in
> HBase Client compoent. The comment says that it is for us to get the number
> of requests since last report, but the code inside this function return the
> number of requests since region server start.
> Here we should change the code
> count += e.getValue().getTotalNumberOfRequests();
> to
> count += e.getValue().getNumberOfRequests();
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12750) getRequestsCount() in ClusterStatus returns total number of request
[ https://issues.apache.org/jira/browse/HBASE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257405#comment-14257405 ] stack commented on HBASE-12750: --- What will master ui report now? Is it dividing what used to be sent by the interval and now this breaks it? > getRequestsCount() in ClusterStatus returns total number of request > --- > > Key: HBASE-12750 > URL: https://issues.apache.org/jira/browse/HBASE-12750 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0, 0.98.6 >Reporter: Weichen Ye >Assignee: Weichen Ye > Fix For: 2.0.0, 0.98.10, 1.1.0 > > Attachments: HBASE-12750.patch > > > getRequestsCount() is a function in org.apache.hadoop.hbase.ClusterStatus in > HBase Client compoent. The comment says that it is for us to get the number > of requests since last report, but the code inside this function return the > number of requests since region server start. > Here we should change the code > count += e.getValue().getTotalNumberOfRequests(); > to > count += e.getValue().getNumberOfRequests(); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
