[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999270#comment-15999270
]
Hudson commented on HBASE-12870:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #223 (See
[https://builds.apache.org/job/HBase-HBASE-14614/223/])
HBASE-12870 "Major compaction triggered" and "Skipping major compaction"
(apurtell: rev 30d0c3fdde39a351912af8484fe48035f4cd9189)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
Addendum patch for HBASE-12870. Added check for null pointer. (apurtell: rev
78f6799f4d53bea368caec77ff32db35109bd96b)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870_addendum.patch, HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995952#comment-15995952
]
Hudson commented on HBASE-12870:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2945 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2945/])
Addendum patch for HBASE-12870. Added check for null pointer. (apurtell: rev
78f6799f4d53bea368caec77ff32db35109bd96b)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870_addendum.patch, HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995889#comment-15995889
]
Hudson commented on HBASE-12870:
FAILURE: Integrated in Jenkins build HBase-1.4 #719 (See
[https://builds.apache.org/job/HBase-1.4/719/])
Addendum patch for HBASE-12870. Added check for null pointer. (apurtell: rev
e08277ac8fe466bf63f6fc342256ab7b8d41243a)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870_addendum.patch, HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995293#comment-15995293
]
Andrew Purtell commented on HBASE-12870:
[~ckulkarni] Would you like to submit an addendum patch to clear the warning?
Apologies for missing it in the report.
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994818#comment-15994818
]
Guanghao Zhang commented on HBASE-12870:
[~apurtell] [~ckulkarni] This commit may introduce a new findbugs warning. See
https://builds.apache.org/job/PreCommit-HBASE-Build/6681/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html.
Thanks.
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994102#comment-15994102
]
Hudson commented on HBASE-12870:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2939 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2939/])
HBASE-12870 "Major compaction triggered" and "Skipping major compaction"
(apurtell: rev 30d0c3fdde39a351912af8484fe48035f4cd9189)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993852#comment-15993852
]
Hudson commented on HBASE-12870:
FAILURE: Integrated in Jenkins build HBase-1.4 #716 (See
[https://builds.apache.org/job/HBase-1.4/716/])
HBASE-12870 "Major compaction triggered" and "Skipping major compaction"
(apurtell: rev d2fcfd74d94b5cd478fb79a1b7fb21cd8902feed)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993393#comment-15993393
]
Andrew Purtell commented on HBASE-12870:
lgtm. We are changing a log line format but it's DEBUG level so can't be
expected to be stable for scraping. Let me run some local checks and then
commit. Thanks [~ckulkarni]
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 1.3.2
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968246#comment-15968246
]
Chinmay Kulkarni commented on HBASE-12870:
--
- Manual testing was done by checking that debug logs print the region
information. This was done by modifying the existing UT
(TestDefaultCompactSelection.java) and setting a RatioBasedCompaction policy.
- The FindBugs error is in a code path that is not touched by this patch.
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 1.3.1
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966708#comment-15966708
]
Hadoop QA commented on HBASE-12870:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 34s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 20s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 16s
{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 101m 36s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 154m 57s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Possible null pointer dereference of CompactionPolicy.storeConfigInfo in
org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.shouldPerformMajorCompaction(Collection)
Dereferenced at
RatioBasedCompactionPolicy.java:CompactionPolicy.storeConfigInfo in
org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy.shouldPerformMajorCompaction(Collection)
Dereferenced at RatioBasedCompactionPolicy.java:[line 75] |
| Failed junit tests | hadoop.hbase.util.TestHBaseFsckTwoRS |
| Timed out junit tests | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor
|
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| | org.apache.hadoop.hbase.util.TestHBaseFsckTwoRS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12863107/HBASE-12870.patch |
| JIRA Issue | HBASE-12870 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ef818c2d58ab 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11
16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
|
[jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
[
https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966371#comment-15966371
]
Andrew Purtell commented on HBASE-12870:
Cam we also include the region information for "Timed out waiting for lock for
row". Been dealing with them for the last couple of days. We can find the info
with a stack dump but would be better if the WARN level log line alerting us to
the condition also carries that information.
> "Major compaction triggered" and "Skipping major compaction" messages lack
> the region information
> -
>
> Key: HBASE-12870
> URL: https://issues.apache.org/jira/browse/HBASE-12870
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Affects Versions: 1.3.1
>Reporter: Hari Krishna Dara
>Assignee: Chinmay Kulkarni
> Labels: compaction, patch
> Fix For: 1.3.1
>
> Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default
> {{.toString()}} output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Major compaction triggered on store
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
> time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG
> org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
> Skipping major compaction of
> org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
> because one (major) compacted file only and oldestTime 6795587394ms is <
> ttl=1555200
> {noformat}
> It should log the store/region information instead. Unfortunately, this
> information seems to be unavailable at this point, so more context needs to
> be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
