[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357062#comment-14357062
]
Hudson commented on HBASE-12931:
FAILURE: Integrated in HBase-0.98 #891 (See
[https://builds.apache.org/job/HBase-0.98/891/])
HBASE-12931 The existing KeyValues in memstore are not removed completely after
inserting cell into memStore (ChiaPing Tsai) (tedyu: rev
d4e82006940bb2df94810350217a7a2df55eca0e)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Attachments: 12931-0.98.txt, HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357083#comment-14357083
]
Hudson commented on HBASE-12931:
FAILURE: Integrated in HBase-1.0 #797 (See
[https://builds.apache.org/job/HBase-1.0/797/])
HBASE-12931 The existing KeyValues in memstore are not removed completely after
inserting cell into memStore (ChiaPing Tsai) (tedyu: rev
0bbb606eae19b45d6905b2f453a76e7a45b3bdc2)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Attachments: 12931-0.98.txt, HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357516#comment-14357516
]
Hudson commented on HBASE-12931:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #848 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/848/])
HBASE-12931 The existing KeyValues in memstore are not removed completely after
inserting cell into memStore (ChiaPing Tsai) (tedyu: rev
d4e82006940bb2df94810350217a7a2df55eca0e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
Attachments: 12931-0.98.txt, HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355325#comment-14355325
]
Andrew Purtell commented on HBASE-12931:
Sorry, I missed this, yes this bugfix seems fine to backport to 0.98.
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351726#comment-14351726
]
Ted Yu commented on HBASE-12931:
Ran TestHFileOutputFormat with patch locally which passed.
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351714#comment-14351714
]
Hadoop QA commented on HBASE-12931:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12703245/HBASE-12931.patch
against master branch at commit 95fc53f1056238e0b5f65df7f3015f2aec3d0a20.
ATTACHMENT ID: 12703245
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat.testMRIncrementalLoadWithSplit(TestHFileOutputFormat.java:378)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13135//console
This message is automatically generated.
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
//
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351719#comment-14351719
]
Hudson commented on HBASE-12931:
SUCCESS: Integrated in HBase-1.1 #261 (See
[https://builds.apache.org/job/HBase-1.1/261/])
HBASE-12931 The existing KeyValues in memstore are not removed completely after
inserting cell into memStore (ChiaPing Tsai) (tedyu: rev
668ab3564942d836a9678f1c2ccd2dae1664cc39)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12931) The existing KeyValues in memstore are not removed completely after inserting cell into memStore
[
https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351735#comment-14351735
]
Hudson commented on HBASE-12931:
SUCCESS: Integrated in HBase-TRUNK #6221 (See
[https://builds.apache.org/job/HBase-TRUNK/6221/])
HBASE-12931 The existing KeyValues in memstore are not removed completely after
inserting cell into memStore (ChiaPing Tsai) (tedyu: rev
76cbf7da650d5858cc4a29a9efc5c64610c09f8b)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
The existing KeyValues in memstore are not removed completely after inserting
cell into memStore
-
Key: HBASE-12931
URL: https://issues.apache.org/jira/browse/HBASE-12931
Project: HBase
Issue Type: Bug
Reporter: ChiaPing Tsai
Assignee: ChiaPing Tsai
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-12931.patch
If I'm not wrong, the UPSERT method of memStore should remove all existing
KeyValues except the newer version.
In memStore,
{code:title=DefaultMemStore.java|borderStyle=solid}
int versIionsVisible = 0;
...
if (cur.getTypeByte() == KeyValue.Type.Put.getCode()
cur.getSequenceId() = readpoint) {
if (versionsVisible 1) {
// if we get here we have seen at least one version visible to
the oldest scanner,
// which means we can prove that no scanner will see this version
// false means there was a change, so give us the size.
long delta = heapSizeChange(cur, true);
addedSize -= delta;
this.size.addAndGet(-delta);
it.remove();
setOldestEditTimeToNow();
} else {
versionsVisible++;
}
{code}
Does versionsVisible 1 should be changed to versionsVisible = 1 ?
thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
