[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-29 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297394#comment-14297394
 ] 

Hudson commented on HBASE-12936:


FAILURE: Integrated in HBase-TRUNK #6067 (See 
[https://builds.apache.org/job/HBase-TRUNK/6067/])
HBASE-12936 Quota support for namespace should take region merge into account 
(tedyu: rev 6bfa8ea977e991c372c0bef7faa49d6142befebc)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionStateListener.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceAuditor.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java


> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 12936-002.txt, 12936-003.txt, 12936-004.txt, 
> 12936-005.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-29 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297022#comment-14297022
 ] 

Ted Yu commented on HBASE-12936:


TestMetaWithReplicas has been fixed by Devaraj.

TestLoadIncrementalHFiles failed in some other QA runs so it was not related.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 12936-002.txt, 12936-003.txt, 12936-004.txt, 
> 12936-005.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296254#comment-14296254
 ] 

Hadoop QA commented on HBASE-12936:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12695128/12936-005.txt
  against master branch at commit 6b20a0f831b195c6f136a3decee61f1d80ebde29.
  ATTACHMENT ID: 12695128

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestMetaWithReplicas
  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12624//console

This message is automatically generated.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt, 12936-004.txt, 
> 12936-005.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296204#comment-14296204
 ] 

Ted Yu commented on HBASE-12936:


>From https://builds.apache.org/job/PreCommit-HBASE-Build/12624/console :
{code}
Running org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
...
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.618 sec - 
in org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
{code}

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt, 12936-004.txt, 
> 12936-005.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295811#comment-14295811
 ] 

Hadoop QA commented on HBASE-12936:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12695045/12936-003.txt
  against master branch at commit 6b20a0f831b195c6f136a3decee61f1d80ebde29.
  ATTACHMENT ID: 12695045

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestMetaWithReplicas
  org.apache.hadoop.hbase.master.TestDistributedLogSplitting

 {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s):   
at 
org.apache.hadoop.hbase.coprocessor.TestMasterObserver.testRegionTransitionOperations(TestMasterObserver.java:1604)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12618//console

This message is automatically generated.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Vandana Ayyalasomayajula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295720#comment-14295720
 ] 

Vandana Ayyalasomayajula commented on HBASE-12936:
--

The test case for merge should have a scenario when merge operation fails.  
Other than that the patch looks good. Thanks [~tedyu]

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295697#comment-14295697
 ] 

Hadoop QA commented on HBASE-12936:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12695035/12936-002.txt
  against master branch at commit 6b20a0f831b195c6f136a3decee61f1d80ebde29.
  ATTACHMENT ID: 12695035

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12617//console

This message is automatically generated.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295660#comment-14295660
 ] 

Enis Soztutar commented on HBASE-12936:
---

LGTM. [~avandana] FYI. 

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295624#comment-14295624
 ] 

Andrew Purtell commented on HBASE-12936:


Let's see if the precommit still has the pertinent zombie from last time:
{noformat}
-1 core zombie tests. There are 1 zombie test(s): at 
org.apache.hadoop.hbase.namespace.TestNamespaceAuditor.testRegionMerge(TestNamespaceAuditor.java:280)
{noformat}


> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt, 12936-003.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295563#comment-14295563
 ] 

Andrew Purtell commented on HBASE-12936:


Well, the question is should the listener be notified before or after the AM 
changes its state. What do you think is better?

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295550#comment-14295550
 ] 

Ted Yu commented on HBASE-12936:


AssignmentManager#onRegionMerged() is not declared to throw IOException.

If there is strong opinion, I can make the move.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295532#comment-14295532
 ] 

Andrew Purtell commented on HBASE-12936:


Skimmed the patch. 

Quick question:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
index 5bc1f2d..5e6c21e 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
@@ -2802,7 +2802,12 @@ public class AssignmentManager {
 errorMsg = onRegionMergePONR(current, hri, serverName, transition);
 break;
   case MERGED:
-errorMsg = onRegionMerged(current, hri, serverName, transition);
+try {
+  regionStateListener.onRegionMerged(hri);
+  errorMsg = onRegionMerged(current, hri, serverName, transition);
+} catch (IOException exp) {
+  errorMsg = StringUtils.stringifyException(exp);
+}
 break;
   case MERGE_REVERTED:
 errorMsg = onRegionMergeReverted(current, hri, serverName, transition);
{code}

Here you are calling the listener's {{onRegionMerged}} callback but it looks 
like the next statement can fail. Should the listener callback be moved to 
after the AM's {{onRegionMerged}} returns? 

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-002.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12936) Quota support for namespace should take region merge into account

2015-01-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295429#comment-14295429
 ] 

Hadoop QA commented on HBASE-12936:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12695005/12936-001.txt
  against master branch at commit 6b20a0f831b195c6f136a3decee61f1d80ebde29.
  ATTACHMENT ID: 12695005

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.namespace.TestNamespaceAuditor.testRegionMerge(TestNamespaceAuditor.java:280)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12616//console

This message is automatically generated.

> Quota support for namespace should take region merge into account
> -
>
> Key: HBASE-12936
> URL: https://issues.apache.org/jira/browse/HBASE-12936
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 12936-001.txt
>
>
> HBASE-8410 added basic quota support for namespaces.
> However, region merge operation was not taken into account. This means, once 
> region count limit is reached, user table cannot be split even after some 
> regions are successfully merged.
> This issue fixes the bug by adding hook in RegionStateListener for region 
> merged event.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)