[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344869#comment-14344869 ] Hudson commented on HBASE-12995: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #836 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/836/]) HBASE-12995 Document that HConnection#getTable methods do not check table existence since 0.98.1 (apurtell: rev b57dbba3178c6ed98359ad9d3b15d3556c911801) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344341#comment-14344341 ] Hudson commented on HBASE-12995: FAILURE: Integrated in HBase-TRUNK #6196 (See [https://builds.apache.org/job/HBase-TRUNK/6196/]) HBASE-12995 Document that HConnection#getTable methods do not check table existence since 0.98.1 (apurtell: rev 0c63eeb5115e7ec538b2d747b8735cb37bae2e69) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Connection.java Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344424#comment-14344424 ] Hadoop QA commented on HBASE-12995: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702029/HBASE-12995-0.98.patch against 0.98 branch at commit 74e36f8ddd03cf94c17bdb30ecd81cc5dff4d063. ATTACHMENT ID: 12702029 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 25 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:red}-1 findbugs{color}. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13047//console This message is automatically generated. Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344390#comment-14344390 ] Hudson commented on HBASE-12995: FAILURE: Integrated in HBase-1.1 #239 (See [https://builds.apache.org/job/HBase-1.1/239/]) HBASE-12995 Document that HConnection#getTable methods do not check table existence since 0.98.1 (apurtell: rev d4200ab39ef8cca668a008c95d267afb24b46047) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Connection.java Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344415#comment-14344415 ] Hudson commented on HBASE-12995: SUCCESS: Integrated in HBase-1.0 #782 (See [https://builds.apache.org/job/HBase-1.0/782/]) HBASE-12995 Document that HConnection#getTable methods do not check table existence since 0.98.1 (apurtell: rev 2dcc920e5f51f96b494f303e71cd9d18690fa760) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Connection.java Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344534#comment-14344534 ] Hudson commented on HBASE-12995: FAILURE: Integrated in HBase-0.98 #878 (See [https://builds.apache.org/job/HBase-0.98/878/]) HBASE-12995 Document that HConnection#getTable methods do not check table existence since 0.98.1 (apurtell: rev b57dbba3178c6ed98359ad9d3b15d3556c911801) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Trivial Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 Attachments: HBASE-12995-0.98.patch, HBASE-12995.patch [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12995) Document that HConnection#getTable methods do not check table existence since 0.98.1
[ https://issues.apache.org/jira/browse/HBASE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312892#comment-14312892 ] Nicolas Liochon commented on HBASE-12995: - Yep, I confirm it's from this the 10080. +1 for the javadoc change, I should have done it in the original jira. Document that HConnection#getTable methods do not check table existence since 0.98.1 Key: HBASE-12995 URL: https://issues.apache.org/jira/browse/HBASE-12995 Project: HBase Issue Type: Task Affects Versions: 0.98.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Priority: Minor Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 [~jamestaylor] mentioned that recently Phoenix discovered at some point the {{HConnection#getTable}} lightweight table reference methods stopped throwing TableNotFoundExceptions. It used to be (in 0.94 and 0.96) that all APIs that construct HTables would check if the table is locatable and throw exceptions if not. Now, if using the {{HConnection#getTable}} APIs, such exceptions will only be thrown at the time of the first operation submitted using the table reference, should a problem be detected then. We did a bisect and it seems this was changed in the 0.98.1 release by HBASE-10080. Since the change has now shipped in 10 in total 0.98 releases we should just document the change, in the javadoc of the HConnection class, Connection in branch-1+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)