[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649773#comment-14649773 ] Sean Busbey commented on HBASE-13114: - fix commit doesn't have the jira in the message: * master: [b728e66708cba45e1a030a8e06971a3c9d431dc7|https://git1-us-west.apache.org/repos/asf?p=hbase.git;a=commit;h=b728e66708cba45e1a030a8e06971a3c9d431dc7] * branch-1: [f6095adea64912deaebfaf2a6a5881b820d315b2|https://git1-us-west.apache.org/repos/asf?p=hbase.git;a=commit;h=f6095adea64912deaebfaf2a6a5881b820d315b2] [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Fix For: 2.0.0, 1.1.0 Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368647#comment-14368647 ] Matteo Bertozzi commented on HBASE-13114: - why we catch any exception from create/delete and go on? shouldn't we fail the test? the outcome after that will be wrong anyway. other than that patch looks good to me. hopefully this stuff will be removed and fixed once and for all with HBASE-13204 [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370309#comment-14370309 ] Hadoop QA commented on HBASE-13114: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705703/0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch against master branch at commit 6a95dd35511f4216481d8d0ffd4952ed1893a1c4. ATTACHMENT ID: 12705703 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13321//console This message is automatically generated. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Fix For: 2.0.0, 1.1.0 Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368701#comment-14368701 ] Hadoop QA commented on HBASE-13114: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705526/0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch against master branch at commit 014b8121031d6268f73f901d54c32a9d880bb12f. ATTACHMENT ID: 12705526 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13309//console This message is automatically generated. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368772#comment-14368772 ] Andrey Stepachev commented on HBASE-13114: -- looks good to me. btw, would it be better to have this observer in HBaseTestingUtility and some minimal infrastructure to handle that in other tests if needed? say we have methods createTable(), that would be good to have them use this observer. what do you think? [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369858#comment-14369858 ] Andrey Stepachev commented on HBASE-13114: -- [~esteban], [~mbertozzi] sounds good. Lets leave this patch as is. Good work, thanks. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369850#comment-14369850 ] Matteo Bertozzi commented on HBASE-13114: - [~octo47] agreed with esteban, we don't need everywhere that complete sync behavior. The only places are the one that really requires that everything is completed. e.g. the ACL checks that are executed in the postOperationHandler, the MasterObserver test because it explicitly want to check that the postOperationHandler is called. and this guy here because it checks an operation that is executed after the delete is considered completed by the client. since the impact of this is mainly in test, and HBASE-13204 may get in 1.1 we may avoid to move out this thing that will be removed anyway at some point. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370110#comment-14370110 ] Matteo Bertozzi commented on HBASE-13114: - [~esteban] sorry I was talking about the debug patch that stack committed, not your code. your code was great and I was committing it already. I was just thinking if we should remove that extra debug in DeleteTableHandler that I'm not really useful how much it is useful. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370125#comment-14370125 ] Esteban Gutierrez commented on HBASE-13114: --- Ha!. Moving from debug to trace is ok in [~stack]'s patch. Let me update my patch with that change and revert the change to trace from the addendum. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Fix For: 2.0.0, 1.1.0 Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370134#comment-14370134 ] stack commented on HBASE-13114: --- The log should never happen. Meta should be cleared when it runs. Ok if you want to make it TRACE but I'd say fine as DEBUG too. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Fix For: 2.0.0, 1.1.0 Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370144#comment-14370144 ] Esteban Gutierrez commented on HBASE-13114: --- I think we can leave it as is for now (i will remove the latest version of my patch to avoid any confusion) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Fix For: 2.0.0, 1.1.0 Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370079#comment-14370079 ] Matteo Bertozzi commented on HBASE-13114: - [~stack] [~esteban] can we remove the extra debug in deleteTableHandler, or at least move it under trace? or do you think is useful? [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370046#comment-14370046 ] Hadoop QA commented on HBASE-13114: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705650/0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch against master branch at commit 27cf749af884edae55454c885c7fb066f0a33c79. ATTACHMENT ID: 12705650 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13320//console This message is automatically generated. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368222#comment-14368222 ] Esteban Gutierrez commented on HBASE-13114: --- Dug into this today, the problem is very similar to HBASE-13182, which is basically that Admin is not really synchronous and it can return earlier when getTableDescriptorByTableName() is null. If we add a sleep of few 100 ms before scanning META after deleting the table the problem is less frequent, however that is only masquerading the real problem. The best option seems to use a latch for now in the same way [~mbertozzi] did in HBASE-13179 and HBASE-13182. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Attachments: 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368554#comment-14368554 ] Hadoop QA commented on HBASE-13114: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705504/0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch against master branch at commit cf7ef936d20b98482a48926a194772c66d3234c1. ATTACHMENT ID: 12705504 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction {color:red}-1 core zombie tests{color}. There are 5 zombie test(s): at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:286) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:260) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:193) at org.apache.hadoop.hbase.ResourceCheckerJUnitListener.testFinished(ResourceCheckerJUnitListener.java:184) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13307//console This message is automatically generated. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: Esteban Gutierrez Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368434#comment-14368434 ] Hadoop QA commented on HBASE-13114: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705486/0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch against master branch at commit f9a17edc252a88c5a1a2c7764e3f9f65623e0ced. ATTACHMENT ID: 12705486 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + public static void createTable(HBaseTestingUtility testUtil, HBaseAdmin admin, HTableDescriptor htd, + public static void deleteTable(HBaseTestingUtility testUtil, HBaseAdmin admin, TableName tableName) {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster org.apache.hadoop.hbase.mapreduce.TestImportExport {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.sqoop.test.testcases.ConnectorTestCase.executeJob(ConnectorTestCase.java:286) at org.apache.sqoop.test.testcases.ConnectorTestCase.executeJob(ConnectorTestCase.java:302) at org.apache.sqoop.integration.connector.jdbc.generic.IncrementalReadTest.testTable(IncrementalReadTest.java:92) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84) at org.testng.internal.Invoker.invokeMethod(Invoker.java:714) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:348) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305) at org.testng.SuiteRunner.run(SuiteRunner.java:254) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224) at org.testng.TestNG.runSuitesLocally(TestNG.java:1149) at org.testng.TestNG.run(TestNG.java:1057) at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:77) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:126) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:110) at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:117) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13305//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368507#comment-14368507 ] stack commented on HBASE-13114: --- Very nice [~esteban] +1 if passes hadoopqa. [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Attachments: 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 0001-UNITTEST-TestEnableTableHandler.testDeleteForSureCle.patch, 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355744#comment-14355744 ] stack commented on HBASE-13114: --- [~octo47] Was 1.0 build IIRC. It failed on 1.1. on apache just recently (no link because builds is down at mo) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Attachments: 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355924#comment-14355924 ] Hudson commented on HBASE-13114: SUCCESS: Integrated in HBase-1.1 #275 (See [https://builds.apache.org/job/HBase-1.1/275/]) HBASE-13114 [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta (stack: rev 619d58f9b5aa6f2d24e5ab8166cddec16a4c1b4b) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestEnableTableHandler.java [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Attachments: 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355958#comment-14355958 ] Hudson commented on HBASE-13114: FAILURE: Integrated in HBase-TRUNK #6237 (See [https://builds.apache.org/job/HBase-TRUNK/6237/]) HBASE-13114 [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta (stack: rev 09e9c92d7699b985f45a48242a24af7c848926f0) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestEnableTableHandler.java [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack Attachments: 13114.txt I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13114) [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta
[ https://issues.apache.org/jira/browse/HBASE-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338785#comment-14338785 ] Andrey Stepachev commented on HBASE-13114: -- what version was it [~stack]? [UNITTEST] TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta - Key: HBASE-13114 URL: https://issues.apache.org/jira/browse/HBASE-13114 Project: HBase Issue Type: Bug Components: test Reporter: stack Assignee: stack I've seen this fail a few times. It just happened now on internal rig. Looking into it {code} REGRESSION: org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta Error Message: expected:0 but was:1 Stack Trace: java.lang.AssertionError: expected:0 but was:1 at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hbase.master.handler.TestEnableTableHandler.testDeleteForSureClearsAllTableRowsFromMeta(TestEnableTableHandler.java:151) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)