[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364280#comment-14364280 ] zhangduo commented on HBASE-13244: -- Yes, not relates. I have posted a comment under HBASE-13172 which tried to fix TestDistributedLogSplitting.testThreeRSAbort. Seems there are other bugs. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362982#comment-14362982 ] zhangduo commented on HBASE-13244: -- Oh, no TestDistributedLogSplitting.testThreeRSAbort failed again... Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362984#comment-14362984 ] Hudson commented on HBASE-13244: SUCCESS: Integrated in HBase-TRUNK #6263 (See [https://builds.apache.org/job/HBase-TRUNK/6263/]) HBASE-13244 addendum add InterfaceAudience annotation back for HBaseKerberosUtils (zhangduo: rev b7e2daa1dbae67aa7148acdb66a8f131a224d7e7) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363371#comment-14363371 ] Elliott Clark commented on HBASE-13244: --- Thanks for the addendum. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363511#comment-14363511 ] stack commented on HBASE-13244: --- bq. TestDistributedLogSplitting.testThreeRSAbort failed again... This issue is not about fixing the above, right [~Apache9]? Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362834#comment-14362834 ] Elliott Clark commented on HBASE-13244: --- For the most part I normally agree with you that src/test is always private unless otherwise specified. However I wouldn't remove the annotation if it was there already. More I was just wondering if you were thinking that this would now need to be public facing. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362846#comment-14362846 ] zhangduo commented on HBASE-13244: -- OK, let me commit an addendum patch which add it back. I agree with you, we should not remove the annotation if it was there already. Thanks [~eclark]. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362943#comment-14362943 ] Hudson commented on HBASE-13244: FAILURE: Integrated in HBase-1.1 #292 (See [https://builds.apache.org/job/HBase-1.1/292/]) HBASE-13244 addendum add InterfaceAudience annotation back for HBaseKerberosUtils (zhangduo: rev 663dacca9d16d05c7ac68e3b5ae51ffd0b60ceed) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244-addendum.patch, HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362394#comment-14362394 ] Ted Yu commented on HBASE-13244: lgtm Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362441#comment-14362441 ] Hudson commented on HBASE-13244: SUCCESS: Integrated in HBase-TRUNK #6262 (See [https://builds.apache.org/job/HBase-TRUNK/6262/]) HBASE-13244 Test delegation token generation with kerberos enabled (zhangduo: rev 0505b7941e175d86004daf9a31ef5ce240d4570f) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestGenerateDelegationToken.java Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362415#comment-14362415 ] zhangduo commented on HBASE-13244: -- Pushed to master and branch-1. Thanks [~tedyu] for reviewing. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[
https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362307#comment-14362307
]
Hadoop QA commented on HBASE-13244:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704644/HBASE-13244.patch
against master branch at commit 01bc979ea29e9282786de13c1cb8cbc107e92e9f.
ATTACHMENT ID: 12704644
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13249//console
This message is automatically generated.
Test delegation token generation with kerberos enabled
--
Key: HBASE-13244
URL: https://issues.apache.org/jira/browse/HBASE-13244
Project: HBase
Issue Type: Sub-task
Components: security, test
Reporter: zhangduo
Assignee: zhangduo
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13244.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362448#comment-14362448 ] Hudson commented on HBASE-13244: SUCCESS: Integrated in HBase-1.1 #291 (See [https://builds.apache.org/job/HBase-1.1/291/]) HBASE-13244 Test delegation token generation with kerberos enabled (zhangduo: rev 6fb6362e28f76c25a0a0aae62e563ffefc593b9e) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestGenerateDelegationToken.java Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362525#comment-14362525 ] Elliott Clark commented on HBASE-13244: --- This removed a @Interface.Private. Can you explain why that was needed ? I'd really like to keep from having more classes that we can't change in future releases. Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13244) Test delegation token generation with kerberos enabled
[ https://issues.apache.org/jira/browse/HBASE-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362615#comment-14362615 ] zhangduo commented on HBASE-13244: -- 'HBaseKerberosUtils' is under src/test, I used to consider that only HBaseTestingUtility and some evaluation tools need @InterfaceAudience. I skimmed the code just now, seems there are other classes under src/test have @InterfaceAudience so I must miss some rules. Can add back, and what is rule of adding @InterfaceAudience to classes under src/test? Thanks, [~eclark] Test delegation token generation with kerberos enabled -- Key: HBASE-13244 URL: https://issues.apache.org/jira/browse/HBASE-13244 Project: HBase Issue Type: Sub-task Components: security, test Reporter: zhangduo Assignee: zhangduo Fix For: 2.0.0, 1.1.0 Attachments: HBASE-13244.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
