[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-27 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975792#comment-14975792
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-1.2 #309 (See 
[https://builds.apache.org/job/HBase-1.2/309/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev c706d42e9e260bfb789bd4ada3ab5c2f5bfa0ead)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975117#comment-14975117
 ] 

Andrew Purtell commented on HBASE-13318:


Ok, committing shortly. Thanks [~lhofhansl] for taking a look

> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975421#comment-14975421
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-1.0 #1100 (See 
[https://builds.apache.org/job/HBase-1.0/1100/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev bbb2f1b0035a9e659c9b7bd7b10515a66881c2ca)
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975426#comment-14975426
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-1.1 #723 (See 
[https://builds.apache.org/job/HBase-1.1/723/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev b7560581752b477df6f824382461d5fb8fc41fd2)
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975646#comment-14975646
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-0.98 #1168 (See 
[https://builds.apache.org/job/HBase-0.98/1168/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev f321d7ec7f2aecfb443619b1fad1dffbf703c420)
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975710#comment-14975710
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1122 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1122/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev f321d7ec7f2aecfb443619b1fad1dffbf703c420)
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975671#comment-14975671
 ] 

Hudson commented on HBASE-13318:


SUCCESS: Integrated in HBase-1.3-IT #273 (See 
[https://builds.apache.org/job/HBase-1.3-IT/273/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev 6fbcd0a2e882a6e60ae0b658bc6620b282d55350)
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975754#comment-14975754
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-1.3 #310 (See 
[https://builds.apache.org/job/HBase-1.3/310/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev 6fbcd0a2e882a6e60ae0b658bc6620b282d55350)
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975651#comment-14975651
 ] 

Hudson commented on HBASE-13318:


SUCCESS: Integrated in HBase-1.2-IT #244 (See 
[https://builds.apache.org/job/HBase-1.2-IT/244/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev c706d42e9e260bfb789bd4ada3ab5c2f5bfa0ead)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-26 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975581#comment-14975581
 ] 

Hudson commented on HBASE-13318:


FAILURE: Integrated in HBase-TRUNK #6963 (See 
[https://builds.apache.org/job/HBase-TRUNK/6963/])
HBASE-13318 RpcServer.getListenerAddress should handle when the accept 
(apurtell: rev efb82957da09ab06f5c887b3d62ad055bbba089f)
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureRPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenInitializing.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* 
hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java


> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-24 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972891#comment-14972891
 ] 

Andrew Purtell commented on HBASE-13318:


Patch that avoids the NPE. Requires callers to care about the potential that 
the listener accept channel has been closed. I think they need to care so did 
it this way. 

> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13318) RpcServer.getListenerAddress should handle when the accept channel is closed

2015-10-24 Thread Lars Hofhansl (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973013#comment-14973013
 ] 

Lars Hofhansl commented on HBASE-13318:
---

Looks good (although I admit I find it hard convince myself that the behaviour 
has not changed).

> RpcServer.getListenerAddress should handle when the accept channel is closed
> 
>
> Key: HBASE-13318
> URL: https://issues.apache.org/jira/browse/HBASE-13318
> Project: HBase
>  Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Andrew Purtell
>Priority: Minor
>  Labels: thread-safety
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3, 0.98.16
>
> Attachments: HBASE-13318.patch
>
>
> We just saw exceptions like these:
> {noformat}
> Exception in thread "B.DefaultRpcServer.handler=45,queue=0,port=60020" 
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer$Listener.getAddress(RpcServer.java:753)
>   at 
> org.apache.hadoop.hbase.ipc.RpcServer.getListenerAddress(RpcServer.java:2157)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:146)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>   at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Looks like RpcServer$Listener.getAddress should be synchronized 
> (acceptChannel is set to null upon exiting the thread under in a synchronized 
> block).
> Should be happening very rarely only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)